[PATCH] net: ethernet: Make OA_TC6 config symbol invisible

[PATCH] net: ethernet: Make OA_TC6 config symbol invisible

[Geert Uytterhoeven]

There is no need to ask the user about enabling OPEN Alliance TC6
10BASE-T1x MAC-PHY support, as all drivers that use this library select
the OA_TC6 symbol.  Hence make the symbol invisible, unless when
compile-testing.

Fixes: aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register write operation")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
index 9a542e3c9b05d877..977b42bc1e8c1e88 100644
--- a/drivers/net/ethernet/Kconfig
+++ b/drivers/net/ethernet/Kconfig
@@ -159,7 +159,7 @@ config ETHOC
 	  Say Y here if you want to use the OpenCores 10/100 Mbps Ethernet MAC.
 
 config OA_TC6
-	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support"
+	tristate "OPEN Alliance TC6 10BASE-T1x MAC-PHY support" if COMPILE_TEST
 	depends on SPI
 	select PHYLIB
 	help
-- 
2.34.1

Re: [PATCH] net: ethernet: Make OA_TC6 config symbol invisible

[Simon Horman]

On Tue, Sep 24, 2024 at 12:20:32PM +0200, Geert Uytterhoeven wrote:
> There is no need to ask the user about enabling OPEN Alliance TC6
> 10BASE-T1x MAC-PHY support, as all drivers that use this library select
> the OA_TC6 symbol.  Hence make the symbol invisible, unless when
> compile-testing.
> 
> Fixes: aa58bec064ab1622 ("net: ethernet: oa_tc6: implement register write operation")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/net/ethernet/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi Geert,

I'm not really convinced this is a fix rather than an enhancement for
net-next.  So my suggestion would be to repost, targeted at net-next, and
without a Fixes tag.

	Subject: [PATCH net-next] ...

In that scenario, if you wish to refer to the commit that introduced this
problem, then you can use the following in the commit message instead
of the Fixes tag. Unlike the fixes tag, I believe it can be line-wrapped.

commit aa58bec064a ("net: ethernet: oa_tc6: implement register write operation")

As it happens, net-next is currently closed for the v6.12 merge window. And
non-RFC patches for net-next should be posted after it re-opens. Which is
scheduled for after the release of v6.12-rc1.

Sorry for all the process nits :^)

-- 
pw-bot: defer