From: Leon Romanovsky <leon@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Feng Wang <wangfe@google.com>,
netdev@vger.kernel.org, antony.antony@secunet.com
Subject: Re: [PATCH] xfrm: add SA information to the offloaded packet
Date: Wed, 25 Sep 2024 11:19:24 +0300 [thread overview]
Message-ID: <20240925081924.GB967758@unreal> (raw)
In-Reply-To: <ZvMAof2+5JET6JRA@gauss3.secunet.de>
On Tue, Sep 24, 2024 at 08:10:41PM +0200, Steffen Klassert wrote:
> Please don't top post!
>
> On Tue, Sep 24, 2024 at 10:57:12AM -0700, Feng Wang wrote:
> > Hi Steffen,
> >
> > The easiest thing would be to upstream your driver, that is the
> > prefered way and would just end this discussion.
> >
> > I will try to upstream the xfrm interface id handling code to
> > netdevsim, thus it will have an in-driver implementation.
>
> Netdevsim is just the second best option and still might
> lead to discussion.
netdevsim should come with relevant selftests, otherwise this
new feature won't be tested properly. We can't rely on someone
out-of-tree to test it.
>
> Upstream the google driver that actually uses it, this _is_
> the prefered way.
+1
>
next prev parent reply other threads:[~2024-09-25 8:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 20:02 [PATCH] xfrm: add SA information to the offloaded packet Feng Wang
2024-08-28 5:32 ` Steffen Klassert
2024-08-28 11:26 ` Leon Romanovsky
2024-08-28 21:25 ` Feng Wang
2024-08-29 10:38 ` Leon Romanovsky
2024-08-29 21:19 ` Feng Wang
2024-08-30 14:30 ` Leon Romanovsky
2024-08-31 0:27 ` Feng Wang
2024-08-31 17:36 ` Leon Romanovsky
2024-08-31 17:39 ` Leon Romanovsky
2024-09-02 7:44 ` Steffen Klassert
2024-09-02 9:44 ` Leon Romanovsky
2024-09-03 18:19 ` Feng Wang
2024-09-03 19:04 ` Leon Romanovsky
2024-09-04 17:41 ` Feng Wang
2024-09-05 7:49 ` Leon Romanovsky
2024-09-05 18:18 ` Feng Wang
2024-09-09 9:09 ` Steffen Klassert
2024-09-09 10:02 ` Steffen Klassert
2024-09-11 10:40 ` Leon Romanovsky
2024-09-11 23:43 ` Feng Wang
2024-09-16 8:10 ` Leon Romanovsky
2024-09-24 10:07 ` Steffen Klassert
2024-09-24 10:34 ` Steffen Klassert
2024-09-24 17:57 ` Feng Wang
2024-09-24 18:10 ` Steffen Klassert
2024-09-25 8:19 ` Leon Romanovsky [this message]
2024-09-25 8:29 ` Leon Romanovsky
2024-09-02 7:47 ` Steffen Klassert
-- strict thread matches above, loose matches on Subject: below --
2024-11-12 19:22 Feng Wang
2024-11-14 10:27 ` Leon Romanovsky
2024-11-18 19:28 ` Feng Wang
2024-11-19 12:51 ` Leon Romanovsky
2024-11-19 19:15 ` Feng Wang
2024-08-12 18:23 Feng Wang
2024-08-19 6:06 ` Steffen Klassert
2024-08-22 20:11 ` Feng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925081924.GB967758@unreal \
--to=leon@kernel.org \
--cc=antony.antony@secunet.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=wangfe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).