From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E09E1A7ADF; Wed, 25 Sep 2024 11:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727265534; cv=none; b=AU6ijL2KqHLf2qDRQ5k1qHZOJUItTupwcdd8/Cm+JoG/MRR4mu0D0Sr/Va09JgBiouCt6ABE528nH0tS9wzmX4U6i8X/9R5uGNrYz3TRf43GtNhAbN37NyRbr1k3ZJ1panZvc+srwqwkU9Jd2CntRKyhA05ixTZpceWwFy7rh1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727265534; c=relaxed/simple; bh=+WpLYJ7yycQNIiw7VTHHHphEGCc9rZ9jaR0okjQ8PX0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XKOS2qxO8KCrTIt6a2TxiA4FarvMDqnrrJ1jcJGMejLB6qYmDCqHIHPdU7Yuy4OLfZvNkZp9FHNUBXiHFJIdBXGhkDUTVuBKzJCOLR0AiPdPcxxlP7Zl26D/mrP0QsSSAvXDyJEWvNVEzf92Hvz2hzvZH3VjrRjNaQ1JM46Z/WM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GQi2R0s6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GQi2R0s6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37988C4CEC7; Wed, 25 Sep 2024 11:58:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727265533; bh=+WpLYJ7yycQNIiw7VTHHHphEGCc9rZ9jaR0okjQ8PX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GQi2R0s68xaiqLRQZj+Td10r+yuyf4Pw0twYxPeWga5E4uyXVJJEXDtLPRsigsr8b PZYcK3V5GlDusGZ9QGCaTpfbB19Uu0rQbRIqYy8xzeQVB/nyQGphQR/0MVhiKAW5e3 LzV5dHpAEROfgGO0w7fSp7K0kMFUkqkPVo/qtXYyzksISlGtUOi9+Ds0hcVlVYwKjm FlnXNtQceY0QUBP6Jj3PZ0Uy82UTCSgxUe8uhXrKzi+XaTh6McSKOm6Q2/TFYOgf7E hWCjYgFHe4jfx0v0GkjiCUsARL9WNsteowcS09C3AergaSSCQaXMBvJsC3XeMAn+cU uOS4kDin6fW2A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Issam Hamdi , Kretschmer Mathias , Johannes Berg , Sasha Levin , johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.10 010/197] wifi: cfg80211: Set correct chandef when starting CAC Date: Wed, 25 Sep 2024 07:50:29 -0400 Message-ID: <20240925115823.1303019-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240925115823.1303019-1-sashal@kernel.org> References: <20240925115823.1303019-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.11 Content-Transfer-Encoding: 8bit From: Issam Hamdi [ Upstream commit 20361712880396e44ce80aaeec2d93d182035651 ] When starting CAC in a mode other than AP mode, it return a "WARNING: CPU: 0 PID: 63 at cfg80211_chandef_dfs_usable+0x20/0xaf [cfg80211]" caused by the chandef.chan being null at the end of CAC. Solution: Ensure the channel definition is set for the different modes when starting CAC to avoid getting a NULL 'chan' at the end of CAC. Call Trace: ? show_regs.part.0+0x14/0x16 ? __warn+0x67/0xc0 ? cfg80211_chandef_dfs_usable+0x20/0xaf [cfg80211] ? report_bug+0xa7/0x130 ? exc_overflow+0x30/0x30 ? handle_bug+0x27/0x50 ? exc_invalid_op+0x18/0x60 ? handle_exception+0xf6/0xf6 ? exc_overflow+0x30/0x30 ? cfg80211_chandef_dfs_usable+0x20/0xaf [cfg80211] ? exc_overflow+0x30/0x30 ? cfg80211_chandef_dfs_usable+0x20/0xaf [cfg80211] ? regulatory_propagate_dfs_state.cold+0x1b/0x4c [cfg80211] ? cfg80211_propagate_cac_done_wk+0x1a/0x30 [cfg80211] ? process_one_work+0x165/0x280 ? worker_thread+0x120/0x3f0 ? kthread+0xc2/0xf0 ? process_one_work+0x280/0x280 ? kthread_complete_and_exit+0x20/0x20 ? ret_from_fork+0x19/0x24 Reported-by: Kretschmer Mathias Signed-off-by: Issam Hamdi Link: https://patch.msgid.link/20240816142418.3381951-1-ih@simonwunderlich.de [shorten subject, remove OCB, reorder cases to match previous list] Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/nl80211.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 967bc4935b4ed..0c2a7542c3d09 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -10023,7 +10023,20 @@ static int nl80211_start_radar_detection(struct sk_buff *skb, err = rdev_start_radar_detection(rdev, dev, &chandef, cac_time_ms); if (!err) { - wdev->links[0].ap.chandef = chandef; + switch (wdev->iftype) { + case NL80211_IFTYPE_AP: + case NL80211_IFTYPE_P2P_GO: + wdev->links[0].ap.chandef = chandef; + break; + case NL80211_IFTYPE_ADHOC: + wdev->u.ibss.chandef = chandef; + break; + case NL80211_IFTYPE_MESH_POINT: + wdev->u.mesh.chandef = chandef; + break; + default: + break; + } wdev->cac_started = true; wdev->cac_start_time = jiffies; wdev->cac_time_ms = cac_time_ms; -- 2.43.0