netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tools/net:Fix the wrong format specifier
@ 2024-09-25  8:55 Zhu Jun
  2024-09-25 19:53 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Zhu Jun @ 2024-09-25  8:55 UTC (permalink / raw)
  To: davem; +Cc: edumazet, pabeni, hawk, zhujun2, netdev, linux-kernel

The format specifier of "unsigned int" in printf() should be "%u", not
"%d".

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/net/ynl/samples/page-pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/ynl/samples/page-pool.c b/tools/net/ynl/samples/page-pool.c
index 332f281ee5cb..e5d521320fbf 100644
--- a/tools/net/ynl/samples/page-pool.c
+++ b/tools/net/ynl/samples/page-pool.c
@@ -118,7 +118,7 @@ int main(int argc, char **argv)
 			name = if_indextoname(s->ifc, ifname);
 			if (name)
 				printf("%8s", name);
-			printf("[%d]\t", s->ifc);
+			printf("[%u]\t", s->ifc);
 		}
 
 		printf("page pools: %u (zombies: %u)\n",
-- 
2.17.1




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/net:Fix the wrong format specifier
  2024-09-25  8:55 [PATCH] tools/net:Fix the wrong format specifier Zhu Jun
@ 2024-09-25 19:53 ` Simon Horman
  2024-09-25 19:59   ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2024-09-25 19:53 UTC (permalink / raw)
  To: Zhu Jun; +Cc: davem, edumazet, pabeni, hawk, netdev, linux-kernel

On Wed, Sep 25, 2024 at 01:55:24AM -0700, Zhu Jun wrote:
> The format specifier of "unsigned int" in printf() should be "%u", not
> "%d".
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Hi Zhu Jun,

Thanks for your patch.

While this change looks good to me it looks like it is for net-next.
Currently net-next is closed for the v6.12 merge window. So please
repost this patch once it reopens, after v6.12-rc1 has been released.
I expect that to happen early next week.

Also, please explicitly target net-next patches for that tree like this:

  Subject: [PATCH net-next]

For reference, netdev processes are documented here:
https://docs.kernel.org/process/maintainer-netdev.html

-- 
pw-bot: defer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/net:Fix the wrong format specifier
  2024-09-25 19:53 ` Simon Horman
@ 2024-09-25 19:59   ` Simon Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-25 19:59 UTC (permalink / raw)
  To: Zhu Jun; +Cc: davem, edumazet, pabeni, hawk, netdev, linux-kernel

On Wed, Sep 25, 2024 at 08:53:54PM +0100, Simon Horman wrote:
> On Wed, Sep 25, 2024 at 01:55:24AM -0700, Zhu Jun wrote:
> > The format specifier of "unsigned int" in printf() should be "%u", not
> > "%d".
> > 
> > Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> 
> Hi Zhu Jun,
> 
> Thanks for your patch.
> 
> While this change looks good to me it looks like it is for net-next.
> Currently net-next is closed for the v6.12 merge window. So please
> repost this patch once it reopens, after v6.12-rc1 has been released.
> I expect that to happen early next week.
> 
> Also, please explicitly target net-next patches for that tree like this:
> 
>   Subject: [PATCH net-next]
> 
> For reference, netdev processes are documented here:
> https://docs.kernel.org/process/maintainer-netdev.html

Sorry, one more thing, looking at git history I think the prefix
for the patch should be 'tools: ynl: '. So perhaps:

   Subject: [PATCH net-next] tools: ynl: correct page-pool stat format specifier

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-25 20:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-25  8:55 [PATCH] tools/net:Fix the wrong format specifier Zhu Jun
2024-09-25 19:53 ` Simon Horman
2024-09-25 19:59   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).