* [PATCH] selftests/net: Add missing va_end.
@ 2024-09-27 4:00 zhangjiao2
2024-09-27 12:21 ` Simon Horman
2024-10-03 8:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: zhangjiao2 @ 2024-09-27 4:00 UTC (permalink / raw)
To: davem
Cc: edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
There is no va_end after va_copy, just add it.
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
tools/testing/selftests/net/tcp_ao/lib/aolib.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/net/tcp_ao/lib/aolib.h b/tools/testing/selftests/net/tcp_ao/lib/aolib.h
index db44e77428dd..5db2f65cddc4 100644
--- a/tools/testing/selftests/net/tcp_ao/lib/aolib.h
+++ b/tools/testing/selftests/net/tcp_ao/lib/aolib.h
@@ -46,6 +46,7 @@ static inline char *test_snprintf(const char *fmt, va_list vargs)
va_copy(tmp, vargs);
n = vsnprintf(ret, size, fmt, tmp);
+ va_end(tmp);
if (n < 0)
return NULL;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: Add missing va_end.
2024-09-27 4:00 [PATCH] selftests/net: Add missing va_end zhangjiao2
@ 2024-09-27 12:21 ` Simon Horman
2024-10-03 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-09-27 12:21 UTC (permalink / raw)
To: zhangjiao2
Cc: davem, edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
On Fri, Sep 27, 2024 at 12:00:50PM +0800, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Thanks, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/net: Add missing va_end.
2024-09-27 4:00 [PATCH] selftests/net: Add missing va_end zhangjiao2
2024-09-27 12:21 ` Simon Horman
@ 2024-10-03 8:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-03 8:50 UTC (permalink / raw)
To: zhangjiao2
Cc: davem, edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 27 Sep 2024 12:00:50 +0800 you wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> There is no va_end after va_copy, just add it.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/net/tcp_ao/lib/aolib.h | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- selftests/net: Add missing va_end.
https://git.kernel.org/netdev/net-next/c/7c2f1c2690a5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-03 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-27 4:00 [PATCH] selftests/net: Add missing va_end zhangjiao2
2024-09-27 12:21 ` Simon Horman
2024-10-03 8:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).