netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries.
@ 2024-09-30 17:34 Javier Carrasco
  2024-09-30 17:34 ` [PATCH 1/3] selftests: net: add msg_oob to gitignore Javier Carrasco
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Javier Carrasco @ 2024-09-30 17:34 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shuah Khan, Allison Henderson
  Cc: netdev, linux-kselftest, linux-kernel, linux-rdma, rds-devel,
	Javier Carrasco

This series is a cherry-pick on top of v6.12-rc1 from the one I sent
for selftests with other patches that were not net-related:

https://lore.kernel.org/all/20240925-selftests-gitignore-v3-0-9db896474170@gmail.com/

The patches have not been modified, and the Reviewed-by tags have
been kept.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
Javier Carrasco (3):
      selftests: net: add msg_oob to gitignore
      selftests: net: rds: add include.sh to EXTRA_CLEAN
      selftests: net: rds: add gitignore file for include.sh

 tools/testing/selftests/net/.gitignore     | 1 +
 tools/testing/selftests/net/rds/.gitignore | 1 +
 tools/testing/selftests/net/rds/Makefile   | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20240930-net-selftests-gitignore-18b844f29391

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@gmail.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] selftests: net: add msg_oob to gitignore
  2024-09-30 17:34 [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Javier Carrasco
@ 2024-09-30 17:34 ` Javier Carrasco
  2024-09-30 17:34 ` [PATCH 2/3] selftests: net: rds: add include.sh to EXTRA_CLEAN Javier Carrasco
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Javier Carrasco @ 2024-09-30 17:34 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shuah Khan, Allison Henderson
  Cc: netdev, linux-kselftest, linux-kernel, linux-rdma, rds-devel,
	Javier Carrasco

This executable is missing from the corresponding gitignore file.
Add msg_oob to the net gitignore list.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/.gitignore b/tools/testing/selftests/net/.gitignore
index 1c04c780db66..9dcdff533414 100644
--- a/tools/testing/selftests/net/.gitignore
+++ b/tools/testing/selftests/net/.gitignore
@@ -17,6 +17,7 @@ ipv6_flowlabel
 ipv6_flowlabel_mgr
 log.txt
 msg_zerocopy
+msg_oob
 ncdevmem
 nettest
 psock_fanout

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] selftests: net: rds: add include.sh to EXTRA_CLEAN
  2024-09-30 17:34 [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Javier Carrasco
  2024-09-30 17:34 ` [PATCH 1/3] selftests: net: add msg_oob to gitignore Javier Carrasco
@ 2024-09-30 17:34 ` Javier Carrasco
  2024-09-30 17:34 ` [PATCH 3/3] selftests: net: rds: add gitignore file for include.sh Javier Carrasco
  2024-10-04 14:40 ` [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Jakub Kicinski
  3 siblings, 0 replies; 5+ messages in thread
From: Javier Carrasco @ 2024-09-30 17:34 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shuah Khan, Allison Henderson
  Cc: netdev, linux-kselftest, linux-kernel, linux-rdma, rds-devel,
	Javier Carrasco

The include.sh file is generated when building the net/rds selftests,
but there is no rule to delete it with the clean target. Add the file to
EXTRA_CLEAN in order to remove it when required.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/rds/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/rds/Makefile b/tools/testing/selftests/net/rds/Makefile
index da9714bc7aad..0b697669ea51 100644
--- a/tools/testing/selftests/net/rds/Makefile
+++ b/tools/testing/selftests/net/rds/Makefile
@@ -7,6 +7,6 @@ TEST_PROGS := run.sh \
 	include.sh \
 	test.py
 
-EXTRA_CLEAN := /tmp/rds_logs
+EXTRA_CLEAN := /tmp/rds_logs include.sh
 
 include ../../lib.mk

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] selftests: net: rds: add gitignore file for include.sh
  2024-09-30 17:34 [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Javier Carrasco
  2024-09-30 17:34 ` [PATCH 1/3] selftests: net: add msg_oob to gitignore Javier Carrasco
  2024-09-30 17:34 ` [PATCH 2/3] selftests: net: rds: add include.sh to EXTRA_CLEAN Javier Carrasco
@ 2024-09-30 17:34 ` Javier Carrasco
  2024-10-04 14:40 ` [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Jakub Kicinski
  3 siblings, 0 replies; 5+ messages in thread
From: Javier Carrasco @ 2024-09-30 17:34 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Shuah Khan, Allison Henderson
  Cc: netdev, linux-kselftest, linux-kernel, linux-rdma, rds-devel,
	Javier Carrasco

The generated include.sh should be ignored by git. Create a new
gitignore and add the file to the list.

Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 tools/testing/selftests/net/rds/.gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/rds/.gitignore b/tools/testing/selftests/net/rds/.gitignore
new file mode 100644
index 000000000000..1c6f04e2aa11
--- /dev/null
+++ b/tools/testing/selftests/net/rds/.gitignore
@@ -0,0 +1 @@
+include.sh

-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries.
  2024-09-30 17:34 [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Javier Carrasco
                   ` (2 preceding siblings ...)
  2024-09-30 17:34 ` [PATCH 3/3] selftests: net: rds: add gitignore file for include.sh Javier Carrasco
@ 2024-10-04 14:40 ` Jakub Kicinski
  3 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2024-10-04 14:40 UTC (permalink / raw)
  To: Javier Carrasco
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Shuah Khan,
	Allison Henderson, netdev, linux-kselftest, linux-kernel,
	linux-rdma, rds-devel

On Mon, 30 Sep 2024 19:34:09 +0200 Javier Carrasco wrote:
> This series is a cherry-pick on top of v6.12-rc1 from the one I sent
> for selftests with other patches that were not net-related:
> 
> https://lore.kernel.org/all/20240925-selftests-gitignore-v3-0-9db896474170@gmail.com/
> 
> The patches have not been modified, and the Reviewed-by tags have
> been kept.

We merged commit 8ed7cf66f484 ("selftests: rds: move include.sh to
TEST_FILES") in meantime, now we have a slight conflict on patch 2.
Could you rebase and repost?

I'd designate the repost as "PATCH net v2", indicating that we probably
want to send these to Linus before 6.12
-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-10-04 14:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 17:34 [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Javier Carrasco
2024-09-30 17:34 ` [PATCH 1/3] selftests: net: add msg_oob to gitignore Javier Carrasco
2024-09-30 17:34 ` [PATCH 2/3] selftests: net: rds: add include.sh to EXTRA_CLEAN Javier Carrasco
2024-09-30 17:34 ` [PATCH 3/3] selftests: net: rds: add gitignore file for include.sh Javier Carrasco
2024-10-04 14:40 ` [PATCH 0/3] selftests: net: add missing gitignore and EXTRA_CLEAN entries Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).