[linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[pierre-henry.moussay]

From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>

PIC64GX CAN is compatible with the MPFS CAN, only add a fallback

Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
---
 .../devicetree/bindings/net/can/microchip,mpfs-can.yaml     | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
index 01e4d4a54df6..1219c5cb601f 100644
--- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
+++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
@@ -15,7 +15,11 @@ allOf:
 
 properties:
   compatible:
-    const: microchip,mpfs-can
+    oneOf:
+      - items:
+          - const: microchip,pic64gx-can
+          - const: microchip,mpfs-can
+      - const: microchip,mpfs-can
 
   reg:
     maxItems: 1
-- 
2.30.2

[linux][PATCH v2 12/20] dt-bindings: net: cdns,macb: Add PIC64GX compatibility

[pierre-henry.moussay]

From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>

PIC64GX uses cdns,macb IP, without additional vendor features

Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
---
 Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
index 3c30dd23cd4e..25ca7f5a7357 100644
--- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
+++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
@@ -38,7 +38,10 @@ properties:
               - cdns,sam9x60-macb     # Microchip sam9x60 SoC
               - microchip,mpfs-macb   # Microchip PolarFire SoC
           - const: cdns,macb          # Generic
-
+      - items:
+          - const: microchip,pic64gx-macb # Microchip PIC64GX SoC
+          - const: microchip,mpfs-macb    # Microchip PolarFire SoC
+          - const: cdns,macb              # Generic
       - items:
           - enum:
               - atmel,sama5d3-macb    # 10/100Mbit IP on Atmel sama5d3 SoCs
-- 
2.30.2

Re: [linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

On Mon, Sep 30, 2024 at 10:54:30AM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> PIC64GX CAN is compatible with the MPFS CAN, only add a fallback
> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [linux][PATCH v2 12/20] dt-bindings: net: cdns,macb: Add PIC64GX compatibility

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1431 bytes --]

On Mon, Sep 30, 2024 at 10:54:41AM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> PIC64GX uses cdns,macb IP, without additional vendor features

That's not really true. There's a mpfs specific match data structure in
the driver which the pic64gx also needs to use.

> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 3c30dd23cd4e..25ca7f5a7357 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -38,7 +38,10 @@ properties:
>                - cdns,sam9x60-macb     # Microchip sam9x60 SoC
>                - microchip,mpfs-macb   # Microchip PolarFire SoC
>            - const: cdns,macb          # Generic
> -
> +      - items:
> +          - const: microchip,pic64gx-macb # Microchip PIC64GX SoC
> +          - const: microchip,mpfs-macb    # Microchip PolarFire SoC
> +          - const: cdns,macb              # Generic
>        - items:
>            - enum:
>                - atmel,sama5d3-macb    # 10/100Mbit IP on Atmel sama5d3 SoCs
> -- 
> 2.30.2
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On 30.09.2024 10:54:30, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> PIC64GX CAN is compatible with the MPFS CAN, only add a fallback
> 
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>

Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>

Who is going to take this patch/series?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

On Mon, Sep 30, 2024 at 06:32:29PM +0200, Marc Kleine-Budde wrote:
> On 30.09.2024 10:54:30, pierre-henry.moussay@microchip.com wrote:
> > From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> > 
> > PIC64GX CAN is compatible with the MPFS CAN, only add a fallback
> > 
> > Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> 
> Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
> 
> Who is going to take this patch/series?

Ideally you take this patch, and other subsystem maintainers take the
ones relevant to their subsystem. And I guess, I take what is left over
along with the dts patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On 30.09.2024 17:37:22, Conor Dooley wrote:
> On Mon, Sep 30, 2024 at 06:32:29PM +0200, Marc Kleine-Budde wrote:
> > On 30.09.2024 10:54:30, pierre-henry.moussay@microchip.com wrote:
> > > From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> > > 
> > > PIC64GX CAN is compatible with the MPFS CAN, only add a fallback
> > > 
> > > Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
> > 
> > Reviewed-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > 
> > Who is going to take this patch/series?
> 
> Ideally you take this patch, and other subsystem maintainers take the
> ones relevant to their subsystem. And I guess, I take what is left over
> along with the dts patches.

Makes sense. Consider it applied to linux-can-next.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]