netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
	jacob.e.keller@intel.com, horms@kernel.org, sd@queasysnail.net,
	chunkeey@gmail.com
Subject: [PATCH net-next 03/13] net: ibm: emac: use devm_platform_ioremap_resource
Date: Mon, 30 Sep 2024 11:00:26 -0700	[thread overview]
Message-ID: <20240930180036.87598-4-rosenp@gmail.com> (raw)
In-Reply-To: <20240930180036.87598-1-rosenp@gmail.com>

No need to have a struct resource. Gets rid of the TODO.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/ibm/emac/core.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index 97ae0b7ccb0d..205ba7aa02d4 100644
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -3050,12 +3050,10 @@ static int emac_probe(struct platform_device *ofdev)
 
 	ndev->irq = dev->emac_irq;
 
-	/* Map EMAC regs */
-	// TODO : platform_get_resource() and devm_ioremap_resource()
-	dev->emacp = devm_of_iomap(&ofdev->dev, np, 0, NULL);
-	if (!dev->emacp) {
+	dev->emacp = devm_platform_ioremap_resource(ofdev, 0);
+	if (IS_ERR(dev->emacp)) {
 		dev_err(&ofdev->dev, "can't map device registers");
-		err = -ENOMEM;
+		err = PTR_ERR(dev->emacp);
 		goto err_gone;
 	}
 
-- 
2.46.2


  parent reply	other threads:[~2024-09-30 18:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 18:00 [PATCH net-next 00/13] ibm: emac: more cleanups Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 01/13] net: ibm: emac: remove custom init/exit functions Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 02/13] net: ibm: emac: use module_platform_driver for modules Rosen Penev
2024-09-30 18:00 ` Rosen Penev [this message]
2024-09-30 18:00 ` [PATCH net-next 04/13] net: ibm: emac: use platform_get_irq Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 05/13] net: ibm: emac: remove bootlist support Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 06/13] net: ibm: emac: tah: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 07/13] net: ibm: emac: tah: devm_platform_get_resources Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 08/13] net: ibm: emac: rgmii: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 09/13] net: ibm: emac: rgmii: devm_platform_get_resource Rosen Penev
2024-10-01  8:24   ` kernel test robot
2024-10-01 13:25     ` Simon Horman
2024-10-01 19:35       ` Rosen Penev
2024-10-01  9:06   ` kernel test robot
2024-09-30 18:00 ` [PATCH net-next 10/13] net: ibm: emac: zmii: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 11/13] net: ibm: emac: zmii: devm_platform_get_resource Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 12/13] net: ibm: emac: mal: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 13/13] net: ibm: emac: mal: use devm for request_irq Rosen Penev
2024-10-01 13:32   ` Simon Horman
2024-10-01 19:35     ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240930180036.87598-4-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=chunkeey@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).