From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
olek2@wp.pl, shannon.nelson@amd.com
Subject: [PATCH net-next 9/9] net: lantiq_etop: no queue stop in remove
Date: Mon, 30 Sep 2024 13:24:34 -0700 [thread overview]
Message-ID: <20240930202434.296960-10-rosenp@gmail.com> (raw)
In-Reply-To: <20240930202434.296960-1-rosenp@gmail.com>
This is already called in stop. No need to call a second time.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/lantiq_etop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 4d8534092667..0b5642744f8a 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -673,10 +673,8 @@ static void ltq_etop_remove(struct platform_device *pdev)
{
struct net_device *dev = platform_get_drvdata(pdev);
- if (dev) {
- netif_tx_stop_all_queues(dev);
+ if (dev)
ltq_etop_hw_exit(dev);
- }
}
static struct platform_driver ltq_mii_driver = {
--
2.46.2
next prev parent reply other threads:[~2024-09-30 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 20:24 [PATCH net-next 0/9] net: lantiq_etop: some cleanups Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 1/9] net: lantiq_etop: use netif_receive_skb_list Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 2/9] net: lantiq_etop: use devm_alloc_etherdev_mqs Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 3/9] net: lantiq_etop: use devm for register_netdev Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 4/9] net: lantiq_etop: use devm for mdiobus Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 5/9] net: lantiq_etop: move phy_disconnect to stop Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 6/9] net: lantiq_etop: use devm_err_probe Rosen Penev
2024-09-30 20:24 ` [PATCH net-next 7/9] net: lantiq_etop: remove struct resource Rosen Penev
2024-10-01 15:33 ` Simon Horman
2024-09-30 20:24 ` [PATCH net-next 8/9] net: lantiq_etop: use module_platform_driver_probe Rosen Penev
2024-09-30 20:24 ` Rosen Penev [this message]
2024-09-30 22:02 ` [PATCH net-next 0/9] net: lantiq_etop: some cleanups Nelson, Shannon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930202434.296960-10-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).