From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
steve.glendinning@shawell.net
Subject: [PATCH net-next 1/8] net: smsc911x: use devm_platform_ioremap_resource
Date: Mon, 30 Sep 2024 15:40:49 -0700 [thread overview]
Message-ID: <20240930224056.354349-2-rosenp@gmail.com> (raw)
In-Reply-To: <20240930224056.354349-1-rosenp@gmail.com>
Allows removal of a bunch of code relating to grabbing resources.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/smsc/smsc911x.c | 47 +++++-----------------------
1 file changed, 7 insertions(+), 40 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index 74f1ccc96459..3d4356df0070 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -2319,7 +2319,6 @@ static void smsc911x_drv_remove(struct platform_device *pdev)
{
struct net_device *dev;
struct smsc911x_data *pdata;
- struct resource *res;
dev = platform_get_drvdata(pdev);
BUG_ON(!dev);
@@ -2334,15 +2333,6 @@ static void smsc911x_drv_remove(struct platform_device *pdev)
mdiobus_unregister(pdata->mii_bus);
mdiobus_free(pdata->mii_bus);
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
- "smsc911x-memory");
- if (!res)
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
- release_mem_region(res->start, resource_size(res));
-
- iounmap(pdata->ioaddr);
-
(void)smsc911x_disable_resources(pdev);
smsc911x_free_resources(pdev);
@@ -2414,21 +2404,9 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
struct net_device *dev;
struct smsc911x_data *pdata;
struct smsc911x_platform_config *config = dev_get_platdata(&pdev->dev);
- struct resource *res;
- int res_size, irq;
+ int irq;
int retval;
- res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
- "smsc911x-memory");
- if (!res)
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- pr_warn("Could not allocate resource\n");
- retval = -ENODEV;
- goto out_0;
- }
- res_size = resource_size(res);
-
irq = platform_get_irq(pdev, 0);
if (irq == -EPROBE_DEFER) {
retval = -EPROBE_DEFER;
@@ -2439,24 +2417,17 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
goto out_0;
}
- if (!request_mem_region(res->start, res_size, SMSC_CHIPNAME)) {
- retval = -EBUSY;
- goto out_0;
- }
-
dev = alloc_etherdev(sizeof(struct smsc911x_data));
- if (!dev) {
- retval = -ENOMEM;
- goto out_release_io_1;
- }
+ if (!dev)
+ return -ENOMEM;
SET_NETDEV_DEV(dev, &pdev->dev);
pdata = netdev_priv(dev);
dev->irq = irq;
- pdata->ioaddr = ioremap(res->start, res_size);
- if (!pdata->ioaddr) {
- retval = -ENOMEM;
+ pdata->ioaddr = devm_platform_ioremap_resource(pdev, 0);
+ if (IS_ERR(pdata->ioaddr)) {
+ retval = PTR_ERR(pdata->ioaddr);
goto out_ioremap_fail;
}
@@ -2467,7 +2438,7 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
retval = smsc911x_request_resources(pdev);
if (retval)
- goto out_request_resources_fail;
+ goto out_ioremap_fail;
retval = smsc911x_enable_resources(pdev);
if (retval)
@@ -2564,12 +2535,8 @@ static int smsc911x_drv_probe(struct platform_device *pdev)
(void)smsc911x_disable_resources(pdev);
out_enable_resources_fail:
smsc911x_free_resources(pdev);
-out_request_resources_fail:
- iounmap(pdata->ioaddr);
out_ioremap_fail:
free_netdev(dev);
-out_release_io_1:
- release_mem_region(res->start, resource_size(res));
out_0:
return retval;
}
--
2.46.2
next prev parent reply other threads:[~2024-09-30 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 22:40 [PATCH net-next 0/8] net: smsc911x: clean up with devm Rosen Penev
2024-09-30 22:40 ` Rosen Penev [this message]
2024-09-30 22:40 ` [PATCH net-next 2/8] net: smsc911x: use devm_alloc_etherdev Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 3/8] net: smsc911x: use devm for regulators Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 4/8] net: smsc911x: use devm for mdiobus functions Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 5/8] net: smsc911x: use devm for register_netdev Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 6/8] net: smsc911x: remove debug stuff from _remove Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 7/8] net: smsc91xx: move down struct members Rosen Penev
2024-10-01 8:54 ` Kalesh Anakkur Purayil
2024-10-01 15:44 ` kernel test robot
2024-09-30 22:40 ` [PATCH net-next 8/8] net: smsc911x: remove pointless NULL checks Rosen Penev
2024-10-01 8:58 ` Kalesh Anakkur Purayil
2024-10-02 12:32 ` [PATCH net-next 0/8] net: smsc911x: clean up with devm Jakub Kicinski
2024-10-02 19:17 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930224056.354349-2-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).