netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
	steve.glendinning@shawell.net
Subject: [PATCH net-next 7/8] net: smsc91xx: move down struct members
Date: Mon, 30 Sep 2024 15:40:55 -0700	[thread overview]
Message-ID: <20240930224056.354349-8-rosenp@gmail.com> (raw)
In-Reply-To: <20240930224056.354349-1-rosenp@gmail.com>

These are only used in these functions.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/smsc/smsc911x.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c
index e757c5825620..5eea873db853 100644
--- a/drivers/net/ethernet/smsc/smsc911x.c
+++ b/drivers/net/ethernet/smsc/smsc911x.c
@@ -131,9 +131,6 @@ struct smsc911x_data {
 
 	/* register access functions */
 	const struct smsc911x_ops *ops;
-
-	/* Reset GPIO */
-	struct gpio_desc *reset_gpiod;
 };
 
 /* Easy access to information */
@@ -378,14 +375,12 @@ static int smsc911x_enable_resources(struct platform_device *pdev)
  */
 static int smsc911x_request_resources(struct platform_device *pdev)
 {
-	struct net_device *ndev = platform_get_drvdata(pdev);
-	struct smsc911x_data *pdata = netdev_priv(ndev);
+	struct gpio_desc *reset_gpiod;
 	struct clk *clk;
 
 	/* Request optional RESET GPIO */
-	pdata->reset_gpiod = devm_gpiod_get_optional(&pdev->dev,
-						     "reset",
-						     GPIOD_OUT_LOW);
+	reset_gpiod =
+		devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_OUT_LOW);
 
 	/* Request clock */
 	clk = devm_clk_get_optional(&pdev->dev, NULL);
-- 
2.46.2


  parent reply	other threads:[~2024-09-30 22:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 22:40 [PATCH net-next 0/8] net: smsc911x: clean up with devm Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 1/8] net: smsc911x: use devm_platform_ioremap_resource Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 2/8] net: smsc911x: use devm_alloc_etherdev Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 3/8] net: smsc911x: use devm for regulators Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 4/8] net: smsc911x: use devm for mdiobus functions Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 5/8] net: smsc911x: use devm for register_netdev Rosen Penev
2024-09-30 22:40 ` [PATCH net-next 6/8] net: smsc911x: remove debug stuff from _remove Rosen Penev
2024-09-30 22:40 ` Rosen Penev [this message]
2024-10-01  8:54   ` [PATCH net-next 7/8] net: smsc91xx: move down struct members Kalesh Anakkur Purayil
2024-10-01 15:44   ` kernel test robot
2024-09-30 22:40 ` [PATCH net-next 8/8] net: smsc911x: remove pointless NULL checks Rosen Penev
2024-10-01  8:58   ` Kalesh Anakkur Purayil
2024-10-02 12:32 ` [PATCH net-next 0/8] net: smsc911x: clean up with devm Jakub Kicinski
2024-10-02 19:17   ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240930224056.354349-8-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steve.glendinning@shawell.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).