From: Conor Dooley <conor@kernel.org>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
git@amd.com, Ravikanth Tuniki <ravikanth.tuniki@amd.com>
Subject: Re: [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Add missing reg minItems
Date: Tue, 1 Oct 2024 18:10:21 +0100 [thread overview]
Message-ID: <20241001-confined-sedative-2917499eb5d6@spud> (raw)
In-Reply-To: <1727723615-2109795-1-git-send-email-radhey.shyam.pandey@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
On Tue, Oct 01, 2024 at 12:43:35AM +0530, Radhey Shyam Pandey wrote:
> From: Ravikanth Tuniki <ravikanth.tuniki@amd.com>
>
> Add missing reg minItems as based on current binding document
> only ethernet MAC IO space is a supported configuration.
>
> There is a bug in schema, current examples contain 64-bit
> addressing as well as 32-bit addressing. The schema validation
> does pass incidentally considering one 64-bit reg address as
> two 32-bit reg address entries. If we change axi_ethernet_eth1
> example node reg addressing to 32-bit schema validation reports:
>
> Documentation/devicetree/bindings/net/xlnx,axi-ethernet.example.dtb:
> ethernet@40000000: reg: [[1073741824, 262144]] is too short
>
> To fix it add missing reg minItems constraints and to make things clearer
> stick to 32-bit addressing in examples.
>
> Fixes: cbb1ca6d5f9a ("dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml")
> Signed-off-by: Ravikanth Tuniki <ravikanth.tuniki@amd.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-10-01 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 19:13 [PATCH net] dt-bindings: net: xlnx,axi-ethernet: Add missing reg minItems Radhey Shyam Pandey
2024-10-01 17:10 ` Conor Dooley [this message]
2024-10-03 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001-confined-sedative-2917499eb5d6@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=ravikanth.tuniki@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox