netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, haren@linux.ibm.com, ricklind@us.ibm.com
Subject: Re: [PATCH net 1/2] ibmvnic: Add stat for tx direct vs tx batched
Date: Tue, 1 Oct 2024 12:08:41 +0100	[thread overview]
Message-ID: <20241001110841.GO1310185@kernel.org> (raw)
In-Reply-To: <20240930175635.1670111-1-nnac123@linux.ibm.com>

On Mon, Sep 30, 2024 at 12:56:34PM -0500, Nick Child wrote:
> Allow tracking of packets sent with send_subcrq direct vs
> indirect. `ethtool -S <dev>` will now provide a counter
> of the number of uses of each xmit method. This metric will
> be useful in performance debugging.
> 
> Signed-off-by: Nick Child <nnac123@linux.ibm.com>

Hi Nick,

While I see that this patch relates to patch 2/2, and I agree that patch
2/2 is net material, this patch seems more like an enhancement and
thus suitable for net-next.

...

      parent reply	other threads:[~2024-10-01 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 17:56 [PATCH net 1/2] ibmvnic: Add stat for tx direct vs tx batched Nick Child
2024-09-30 17:56 ` [PATCH net 2/2] ibmvnic: Inspect header requirements before using scrq direct Nick Child
2024-10-01 11:07   ` Simon Horman
2024-10-01 11:08 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241001110841.GO1310185@kernel.org \
    --to=horms@kernel.org \
    --cc=haren@linux.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=nnac123@linux.ibm.com \
    --cc=ricklind@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).