* [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices
@ 2024-09-30 17:45 Marc Kleine-Budde
2024-10-01 11:12 ` Simon Horman
2024-10-01 12:48 ` Markus Schneider-Pargmann
0 siblings, 2 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2024-09-30 17:45 UTC (permalink / raw)
To: Chandrasekar Ramakrishnan, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Tony Lindgren,
Judith Mendez, Markus Schneider-Pargmann
Cc: linux-can, netdev, linux-kernel, kernel, Marc Kleine-Budde
In commit b382380c0d2d ("can: m_can: Add hrtimer to generate software
interrupt") support for IRQ-less devices was added. Instead of an
interrupt, the interrupt routine is called by a hrtimer-based polling
loop.
That patch forgot to change free_irq() to be only called for devices
with IRQs. Fix this, by calling free_irq() conditionally only if an
IRQ is available for the device (and thus has been requested
previously).
Fixes: b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/m_can/m_can.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index a978b960f1f1e1e8273216ff330ab789d0fd6d51..16e9e7d7527d9762d73a7ec47940c73c0976e05d 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1765,7 +1765,8 @@ static int m_can_close(struct net_device *dev)
netif_stop_queue(dev);
m_can_stop(dev);
- free_irq(dev->irq, dev);
+ if (dev->irq)
+ free_irq(dev->irq, dev);
m_can_clean(dev);
---
base-commit: d505d3593b52b6c43507f119572409087416ba28
change-id: 20240930-m_can-cleanups-53ce4276f1b1
Best regards,
--
Marc Kleine-Budde <mkl@pengutronix.de>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices
2024-09-30 17:45 [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices Marc Kleine-Budde
@ 2024-10-01 11:12 ` Simon Horman
2024-10-01 12:48 ` Markus Schneider-Pargmann
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-10-01 11:12 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Chandrasekar Ramakrishnan, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Tony Lindgren,
Judith Mendez, Markus Schneider-Pargmann, linux-can, netdev,
linux-kernel, kernel
On Mon, Sep 30, 2024 at 07:45:57PM +0200, Marc Kleine-Budde wrote:
> In commit b382380c0d2d ("can: m_can: Add hrtimer to generate software
> interrupt") support for IRQ-less devices was added. Instead of an
> interrupt, the interrupt routine is called by a hrtimer-based polling
> loop.
>
> That patch forgot to change free_irq() to be only called for devices
> with IRQs. Fix this, by calling free_irq() conditionally only if an
> IRQ is available for the device (and thus has been requested
> previously).
>
> Fixes: b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices
2024-09-30 17:45 [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices Marc Kleine-Budde
2024-10-01 11:12 ` Simon Horman
@ 2024-10-01 12:48 ` Markus Schneider-Pargmann
1 sibling, 0 replies; 3+ messages in thread
From: Markus Schneider-Pargmann @ 2024-10-01 12:48 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Chandrasekar Ramakrishnan, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Tony Lindgren,
Judith Mendez, linux-can, netdev, linux-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]
On Mon, Sep 30, 2024 at 07:45:57PM GMT, Marc Kleine-Budde wrote:
> In commit b382380c0d2d ("can: m_can: Add hrtimer to generate software
> interrupt") support for IRQ-less devices was added. Instead of an
> interrupt, the interrupt routine is called by a hrtimer-based polling
> loop.
>
> That patch forgot to change free_irq() to be only called for devices
> with IRQs. Fix this, by calling free_irq() conditionally only if an
> IRQ is available for the device (and thus has been requested
> previously).
>
> Fixes: b382380c0d2d ("can: m_can: Add hrtimer to generate software interrupt")
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Reviewed-by: Markus Schneider-Pargmann <msp@baylibre.com>
Best
Markus
> ---
> drivers/net/can/m_can/m_can.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index a978b960f1f1e1e8273216ff330ab789d0fd6d51..16e9e7d7527d9762d73a7ec47940c73c0976e05d 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -1765,7 +1765,8 @@ static int m_can_close(struct net_device *dev)
> netif_stop_queue(dev);
>
> m_can_stop(dev);
> - free_irq(dev->irq, dev);
> + if (dev->irq)
> + free_irq(dev->irq, dev);
>
> m_can_clean(dev);
>
>
> ---
> base-commit: d505d3593b52b6c43507f119572409087416ba28
> change-id: 20240930-m_can-cleanups-53ce4276f1b1
>
> Best regards,
> --
> Marc Kleine-Budde <mkl@pengutronix.de>
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-01 12:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-30 17:45 [PATCH] can: m_can: m_can_close(): don't call free_irq() for IRQ-less devices Marc Kleine-Budde
2024-10-01 11:12 ` Simon Horman
2024-10-01 12:48 ` Markus Schneider-Pargmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).