From: Moon Yeounsu <yyyynoom@gmail.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux@weissschuh.net, j.granados@samsung.com,
judyhsiao@chromium.org, James.Z.Li@Dell.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Moon Yeounsu <yyyynoom@gmail.com>
Subject: [PATCH net] net: add inline annotation to fix the build warning
Date: Wed, 2 Oct 2024 04:33:52 +0900 [thread overview]
Message-ID: <20241001193352.151102-1-yyyynoom@gmail.com> (raw)
This patch fixes two `sparse` warnings:
net/core/neighbour.c:453:9: warning: context imbalance in '__neigh_ifdown' - wrong count at exit
net/core/neighbour.c:871:9: warning: context imbalance in 'pneigh_ifdown_and_unlock' - unexpected unlock
You can check it by running:
`make C=1 net/core/neighbour.o`
Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
---
net/core/neighbour.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 77b819cd995b..6b5ec9a44556 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -441,6 +441,7 @@ EXPORT_SYMBOL(neigh_changeaddr);
static int __neigh_ifdown(struct neigh_table *tbl, struct net_device *dev,
bool skip_perm)
+ __acquires(&tbl->lock)
{
write_lock_bh(&tbl->lock);
neigh_flush_dev(tbl, dev, skip_perm);
@@ -453,6 +454,7 @@ static int __neigh_ifdown(struct neigh_table *tbl, struct net_device *dev,
}
int neigh_carrier_down(struct neigh_table *tbl, struct net_device *dev)
+ __acquires(&tbl->lock)
{
__neigh_ifdown(tbl, dev, true);
return 0;
@@ -460,6 +462,7 @@ int neigh_carrier_down(struct neigh_table *tbl, struct net_device *dev)
EXPORT_SYMBOL(neigh_carrier_down);
int neigh_ifdown(struct neigh_table *tbl, struct net_device *dev)
+ __acquires(&tbl->lock)
{
__neigh_ifdown(tbl, dev, false);
return 0;
@@ -848,6 +851,7 @@ int pneigh_delete(struct neigh_table *tbl, struct net *net, const void *pkey,
static int pneigh_ifdown_and_unlock(struct neigh_table *tbl,
struct net_device *dev)
+ __releases(&tbl->lock)
{
struct pneigh_entry *n, **np, *freelist = NULL;
u32 h;
--
2.46.1
next reply other threads:[~2024-10-01 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 19:33 Moon Yeounsu [this message]
[not found] ` <CAAjsZQx1NFdx8HyBmDqDxQbUvcxbaag5y-ft+feWLgQeb1Qfdw@mail.gmail.com>
2024-10-02 14:41 ` [PATCH net] net: add inline annotation to fix the build warning Eric Dumazet
2024-10-03 13:56 ` Moon Yeounsu
2024-10-03 14:19 ` Eric Dumazet
2024-10-03 15:33 ` Moon Yeounsu
2024-10-03 16:11 ` Edward Cree
2024-10-03 18:39 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2024-09-19 14:21 Moon Yeounsu
2024-09-19 14:56 ` Simon Horman
2024-09-20 7:27 ` Moon Yeounsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001193352.151102-1-yyyynoom@gmail.com \
--to=yyyynoom@gmail.com \
--cc=James.Z.Li@Dell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.granados@samsung.com \
--cc=judyhsiao@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).