From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Jeffrey Ji <jeffreyji@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD_HORIZON device attribute
Date: Wed, 2 Oct 2024 06:47:35 -0700 [thread overview]
Message-ID: <20241002064735.5b1127ab@kernel.org> (raw)
In-Reply-To: <20240930152304.472767-2-edumazet@google.com>
On Mon, 30 Sep 2024 15:23:03 +0000 Eric Dumazet wrote:
> @@ -1867,6 +1868,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb,
> READ_ONCE(dev->tso_max_size)) ||
> nla_put_u32(skb, IFLA_TSO_MAX_SEGS,
> READ_ONCE(dev->tso_max_segs)) ||
> + nla_put_u64_64bit(skb, IFLA_MAX_PACING_OFFLOAD_HORIZON,
> + READ_ONCE(dev->max_pacing_offload_horizon),
> + IFLA_PAD) ||
nla_put_uint() ?
> #ifdef CONFIG_RPS
> nla_put_u32(skb, IFLA_NUM_RX_QUEUES,
> READ_ONCE(dev->num_rx_queues)) ||
> @@ -2030,6 +2034,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
> [IFLA_ALLMULTI] = { .type = NLA_REJECT },
> [IFLA_GSO_IPV4_MAX_SIZE] = { .type = NLA_U32 },
> [IFLA_GRO_IPV4_MAX_SIZE] = { .type = NLA_U32 },
> + [IFLA_MAX_PACING_OFFLOAD_HORIZON]= { .type = NLA_REJECT },
Let's do this instead ?
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f0a520987085..a68de5c15b46 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1975,6 +1975,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb,
}
static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
+ [IFLA_UNSPEC] = { .strict_start_type = IFLA_DPLL_PIN },
[IFLA_IFNAME] = { .type = NLA_STRING, .len = IFNAMSIZ-1 },
[IFLA_ADDRESS] = { .type = NLA_BINARY, .len = MAX_ADDR_LEN },
[IFLA_BROADCAST] = { .type = NLA_BINARY, .len = MAX_ADDR_LEN },
next prev parent reply other threads:[~2024-10-02 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 15:23 [PATCH net-next 0/2] net: prepare pacing offload support Eric Dumazet
2024-09-30 15:23 ` [PATCH net-next 1/2] net: add IFLA_MAX_PACING_OFFLOAD_HORIZON device attribute Eric Dumazet
2024-09-30 18:36 ` Willem de Bruijn
2024-10-02 13:47 ` Jakub Kicinski [this message]
2024-10-02 14:06 ` Eric Dumazet
2024-09-30 15:23 ` [PATCH net-next 2/2] net_sched: sch_fq: add the ability to offload pacing Eric Dumazet
2024-09-30 17:33 ` Willem de Bruijn
2024-09-30 17:55 ` Eric Dumazet
2024-09-30 18:17 ` Willem de Bruijn
2024-09-30 18:38 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002064735.5b1127ab@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jeffreyji@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).