From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, claudiu.manoil@nxp.com
Subject: Re: [PATCH net-next 3/6] net: gianfar: allocate queues with devm
Date: Wed, 2 Oct 2024 09:25:09 +0200 [thread overview]
Message-ID: <20241002092509.1b56b470@fedora.home> (raw)
In-Reply-To: <20241001212204.308758-4-rosenp@gmail.com>
On Tue, 1 Oct 2024 14:22:01 -0700
Rosen Penev <rosenp@gmail.com> wrote:
> There seems to be a mistake here where free_tx_queue is called on
> failure. Just let devm deal with it.
Good catch, this looks good to me.
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Maxime
next prev parent reply other threads:[~2024-10-02 7:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 21:21 [PATCH net-next 0/6] gianfar cleanups Rosen Penev
2024-10-01 21:21 ` [PATCH net-next 1/6] net: gianfar: use devm_alloc_etherdev_mqs Rosen Penev
2024-10-02 7:15 ` Maxime Chevallier
2024-10-01 21:22 ` [PATCH net-next 2/6] net: gianfar: remove free_gfar_dev Rosen Penev
2024-10-02 7:23 ` Maxime Chevallier
2024-10-01 21:22 ` [PATCH net-next 3/6] net: gianfar: allocate queues with devm Rosen Penev
2024-10-02 7:25 ` Maxime Chevallier [this message]
2024-10-04 6:31 ` Claudiu Manoil
2024-10-01 21:22 ` [PATCH net-next 4/6] net: gianfar: use devm for register_netdev Rosen Penev
2024-10-02 7:29 ` Maxime Chevallier
2024-10-02 19:40 ` Rosen Penev
2024-10-01 21:22 ` [PATCH net-next 5/6] net: gianfar: use devm for request_irq Rosen Penev
2024-10-02 7:37 ` Maxime Chevallier
2024-10-02 19:29 ` Rosen Penev
2024-10-02 21:32 ` Andrew Lunn
2024-10-03 19:37 ` Claudiu Manoil
2024-10-01 21:22 ` [PATCH net-next 6/6] net: gianfar: use devm for of_iomap Rosen Penev
2024-10-02 7:47 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002092509.1b56b470@fedora.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).