From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Joe Damato <jdamato@fastly.com>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>,
Simon Horman <horms@kernel.org>
Subject: Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size
Date: Wed, 2 Oct 2024 10:17:27 -0700 [thread overview]
Message-ID: <20241002101727.349fc146@kernel.org> (raw)
In-Reply-To: <ZvwK1PnvREjf_wvK@LQ3V64L9R2>
On Tue, 1 Oct 2024 07:44:36 -0700 Joe Damato wrote:
> > But if you change any core API, let's say rename a field used in several
> > drivers, you anyway need to adjust the affected drivers.
>
> Sorry, but that's a totally different argument.
>
> There are obvious cases where touching certain parts of core would
> require changes to drivers, yes. I agree on that if I change an API
> or a struct field name, or remove an enum, then this affects drivers
> which must be updated.
+1
I fully agree with Joe. Drivers asserting the size of core structures
is both undue burden on core changes and pointless.
The former is subjective, as for the latter: most core structures
will contain cold / slow path data, usually at the end. If you care
about performance of anything that follows a core struct you need
to align the next field yourself.
IDK how you want to fit this into your magic macros but complex
nested types should be neither ro, rw nor cold. They are separate.
next prev parent reply other threads:[~2024-10-02 17:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:00 [RFC net-next 0/1] idpf: Don't hardcode napi_struct size Joe Damato
2024-09-25 18:00 ` [RFC net-next 1/1] idpf: Don't hard code " Joe Damato
2024-09-25 20:33 ` Simon Horman
2024-09-30 12:33 ` Alexander Lobakin
2024-09-30 12:38 ` Alexander Lobakin
2024-09-30 13:10 ` Przemek Kitszel
2024-09-30 22:17 ` Joe Damato
2024-10-01 13:14 ` Alexander Lobakin
2024-10-01 14:44 ` Joe Damato
2024-10-02 17:17 ` Jakub Kicinski [this message]
2024-10-03 13:35 ` Alexander Lobakin
2024-10-03 15:46 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002101727.349fc146@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).