From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next 01/10] lib: packing: refuse operating on bit indices which exceed size of buffer
Date: Wed, 2 Oct 2024 16:44:06 +0300 [thread overview]
Message-ID: <20241002134406.a5vpk2cli5nqlvfu@skbuf> (raw)
In-Reply-To: <20240930-packing-kunit-tests-and-split-pack-unpack-v1-1-94b1f04aca85@intel.com>
On Mon, Sep 30, 2024 at 04:19:34PM -0700, Jacob Keller wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> While reworking the implementation, it became apparent that this check
> does not exist.
>
> There is no functional issue yet, because at call sites, "startbit" and
> "endbit" are always hardcoded to correct values, and never come from the
> user.
>
> Even with the upcoming support of arbitrary buffer lengths, the
> "startbit >= 8 * pbuflen" check will remain correct. This is because
> we intend to always interpret the packed buffer in a way that avoids
> discontinuities in the available bit indices.
>
> Fixes: 554aae35007e ("lib: Add support for generic packing operations")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Tested-by: Jacob Keller <jacob.e.keller@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> ---
I thought that Fixes: tags are not in order for patches which are not
intended to be backported, and that is also clear from the commit message?
next prev parent reply other threads:[~2024-10-02 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 23:19 [PATCH net-next 00/10] packing: various improvements and KUnit tests Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 01/10] lib: packing: refuse operating on bit indices which exceed size of buffer Jacob Keller
2024-10-02 13:44 ` Vladimir Oltean [this message]
2024-10-02 21:28 ` Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 02/10] lib: packing: adjust definitions and implementation for arbitrary buffer lengths Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 03/10] lib: packing: remove kernel-doc from header file Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 04/10] lib: packing: add pack() and unpack() wrappers over packing() Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 05/10] lib: packing: duplicate pack() and unpack() implementations Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 06/10] lib: packing: add KUnit tests adapted from selftests Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 07/10] lib: packing: add additional KUnit tests Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 08/10] lib: packing: fix QUIRK_MSB_ON_THE_RIGHT behavior Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 09/10] lib: packing: use BITS_PER_BYTE instead of 8 Jacob Keller
2024-09-30 23:19 ` [PATCH net-next 10/10] lib: packing: use GENMASK() for box_mask Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002134406.a5vpk2cli5nqlvfu@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox