From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-52002.amazon.com (smtp-fw-52002.amazon.com [52.119.213.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AD641D0E35; Wed, 2 Oct 2024 15:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.119.213.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727882760; cv=none; b=aYTMfVmoXkkqajo9VD7uLF9n096gK6tDta2xpVfCbTVwxnvqUINpoHlYuGg7fJRnW/8kyR8S/jSl2EWyVD0EIPD3P+yOyfuSVvWE0pngvgefpoqC0hpNiF3XSujDN8E+yR1zLtdb//Ib+UPJjxP7feDfJJt/VZTgMMruLmD9GoA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727882760; c=relaxed/simple; bh=lKhyf48RMLpspZ3ymS6szfFA1piNDk8WumAeRcg/MuQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mMNGhbLyShLeHvQdHR9iQABR6dEe0eMpsEMl6fXYG9tM8JBi7bNRGNcnUYJPT4tcz+CJSqtVIW8BnAqcLJFeVc4LN/GELyOBIfAo4XPyKQH/2TzXRzSgibFR8tHk1g5hNvVfy346kAF2ILNCkji6fFgcig5bmpEe/ElNxkP0ZIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=LkNpzt8n; arc=none smtp.client-ip=52.119.213.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="LkNpzt8n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1727882759; x=1759418759; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yz3Wsj7pxR718E2/bctzq5t+/Vno2EGn0C6LCYN4jtw=; b=LkNpzt8nVC5i2Eaky0++AlQbVSWBlZnIoYMp9iuSY6I2aHrDWEURbNG2 w6eCrMiESDtz7M2CfC7cohCIlPKRBzo3sgzK/fB3CjRYKpk98LtxcOsij nE4gpmownESby9VLhAQ+clmtEqZRDoE14jggcILCRHDGMNlqM2UYgTJqw Y=; X-IronPort-AV: E=Sophos;i="6.11,172,1725321600"; d="scan'208";a="663149872" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-52002.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 15:25:53 +0000 Received: from EX19MTAUWB002.ant.amazon.com [10.0.38.20:2518] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.24.191:2525] with esmtp (Farcaster) id f7d7adac-7501-46c1-8368-2fe41a4590eb; Wed, 2 Oct 2024 15:25:51 +0000 (UTC) X-Farcaster-Flow-ID: f7d7adac-7501-46c1-8368-2fe41a4590eb Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.34; Wed, 2 Oct 2024 15:25:51 +0000 Received: from 88665a182662.ant.amazon.com (10.187.171.23) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1258.35; Wed, 2 Oct 2024 15:25:48 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , , , Subject: Re: [PATCH net-next] net: Implement fault injection forcing skb reallocation Date: Wed, 2 Oct 2024 08:25:40 -0700 Message-ID: <20241002152540.51408-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20241002113316.2527669-1-leitao@debian.org> References: <20241002113316.2527669-1-leitao@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D042UWB001.ant.amazon.com (10.13.139.160) To EX19D004ANA001.ant.amazon.com (10.37.240.138) From: Breno Leitao Date: Wed, 2 Oct 2024 04:32:54 -0700 > diff --git a/net/Kconfig.debug b/net/Kconfig.debug > index 5e3fffe707dd..f61935e028bd 100644 > --- a/net/Kconfig.debug > +++ b/net/Kconfig.debug This config is networking-specific, but I think lib/Kconfig.debug would be a better fit as other fault injection configs are placed there together. Now we need to enable fault injection first and go back to the net-specific items in menuconfig. > @@ -24,3 +24,14 @@ config DEBUG_NET > help > Enable extra sanity checks in networking. > This is mostly used by fuzzers, but is safe to select. > + > +config FAIL_SKB_FORCE_REALLOC > + bool "Fault-injection capability forcing skb to reallocate" > + depends on FAULT_INJECTION && DEBUG_NET > + default n > + help > + Provide fault-injection capability that forces the skb to be > + reallocated, caughting possible invalid pointers to the skb. > + > + For more information, check > + Documentation/dev-tools/fault-injection/fault-injection.rst