From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "Mogilappagari, Sudheer" <sudheer.mogilappagari@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Michal Kubecek <mkubecek@suse.cz>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL_GRXRINGS ioctl
Date: Thu, 3 Oct 2024 12:18:10 +0300 [thread overview]
Message-ID: <20241003091810.2zbbvod4jqq246lq@skbuf> (raw)
In-Reply-To: <45327ee6-e57c-4fec-bf43-86bd1338f5fb@intel.com>
Hello Jake,
On Thu, Sep 19, 2024 at 10:58:48AM -0700, Jacob Keller wrote:
> We could extend the netlink interface to add this over netlink instead
> of ioctl, but that hasn't been done yet.
Let me understand how this will play out. So you're proposing that we
add a new netlink attribute in ETHTOOL_MSG_RSS_GET_REPLY, with Fixes:
7112a04664bf ("ethtool: add netlink based get rss support"), and this
gets backported to all stable kernels which include this commit?
And then also 'fix' ethtool to parse this new netlink attribute instead
of ETHTOOL_A_CHANNELS_RX_COUNT? Thus introducing another breakage: when
the new ethtool program runs with the old (aka unpatched stable) kernel?
next prev parent reply other threads:[~2024-10-03 9:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 9:38 [PATCH ethtool] netlink: rss: retrieve ring count using ETHTOOL_GRXRINGS ioctl Vladimir Oltean
2024-09-13 20:34 ` Jakub Kicinski
2024-09-13 22:43 ` Mogilappagari, Sudheer
2024-09-13 22:45 ` Mogilappagari, Sudheer
2024-09-13 22:48 ` Vladimir Oltean
2024-09-13 23:07 ` Mogilappagari, Sudheer
2024-09-19 17:58 ` Jacob Keller
2024-10-03 9:18 ` Vladimir Oltean [this message]
2024-10-03 11:09 ` Michal Kubecek
2024-10-03 13:49 ` Vladimir Oltean
2024-10-03 23:20 ` Michal Kubecek
2024-10-04 19:19 ` Keller, Jacob E
2024-10-05 7:46 ` Michal Kubecek
2024-10-07 22:12 ` Jacob Keller
2024-09-16 19:38 ` Michal Kubecek
2024-09-17 15:10 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003091810.2zbbvod4jqq246lq@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox