From: Taehee Yoo <ap420073@gmail.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, almasrymina@google.com,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
donald.hunter@gmail.com, corbet@lwn.net,
michael.chan@broadcom.com
Cc: kory.maincent@bootlin.com, andrew@lunn.ch,
maxime.chevallier@bootlin.com, danieller@nvidia.com,
hengqi@linux.alibaba.com, ecree.xilinx@gmail.com,
przemyslaw.kitszel@intel.com, hkallweit1@gmail.com,
ahmed.zaki@intel.com, paul.greenwalt@intel.com,
rrameshbabu@nvidia.com, idosch@nvidia.com,
asml.silence@gmail.com, kaiyuanz@google.com, willemb@google.com,
aleksander.lobakin@intel.com, dw@davidwei.uk,
sridhar.samudrala@intel.com, bcreeley@amd.com,
ap420073@gmail.com
Subject: [PATCH net-next v3 5/7] net: devmem: add ring parameter filtering
Date: Thu, 3 Oct 2024 16:06:18 +0000 [thread overview]
Message-ID: <20241003160620.1521626-6-ap420073@gmail.com> (raw)
In-Reply-To: <20241003160620.1521626-1-ap420073@gmail.com>
If driver doesn't support ring parameter or tcp-data-split configuration
is not sufficient, the devmem should not be set up.
Before setup the devmem, tcp-data-split should be ON and
tcp-data-split-thresh value should be 0.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
v3:
- Patch added.
net/core/devmem.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/net/core/devmem.c b/net/core/devmem.c
index 11b91c12ee11..a9e9b15028e0 100644
--- a/net/core/devmem.c
+++ b/net/core/devmem.c
@@ -8,6 +8,8 @@
*/
#include <linux/dma-buf.h>
+#include <linux/ethtool.h>
+#include <linux/ethtool_netlink.h>
#include <linux/genalloc.h>
#include <linux/mm.h>
#include <linux/netdevice.h>
@@ -131,6 +133,8 @@ int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
struct net_devmem_dmabuf_binding *binding,
struct netlink_ext_ack *extack)
{
+ struct kernel_ethtool_ringparam kernel_ringparam = {};
+ struct ethtool_ringparam ringparam = {};
struct netdev_rx_queue *rxq;
u32 xa_idx;
int err;
@@ -146,6 +150,20 @@ int net_devmem_bind_dmabuf_to_queue(struct net_device *dev, u32 rxq_idx,
return -EEXIST;
}
+ if (!dev->ethtool_ops->get_ringparam) {
+ NL_SET_ERR_MSG(extack, "can't get ringparam");
+ return -EINVAL;
+ }
+
+ dev->ethtool_ops->get_ringparam(dev, &ringparam,
+ &kernel_ringparam, extack);
+ if (kernel_ringparam.tcp_data_split != ETHTOOL_TCP_DATA_SPLIT_ENABLED ||
+ kernel_ringparam.tcp_data_split_thresh) {
+ NL_SET_ERR_MSG(extack,
+ "tcp-header-data-split is disabled or threshold is not zero");
+ return -EINVAL;
+ }
+
#ifdef CONFIG_XDP_SOCKETS
if (rxq->pool) {
NL_SET_ERR_MSG(extack, "designated queue already in use by AF_XDP");
--
2.34.1
next prev parent reply other threads:[~2024-10-03 16:07 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:06 [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 1/7] bnxt_en: add support for rx-copybreak ethtool command Taehee Yoo
2024-10-03 16:57 ` Brett Creeley
2024-10-03 17:15 ` Taehee Yoo
2024-10-03 17:13 ` Michael Chan
2024-10-03 17:22 ` Taehee Yoo
2024-10-03 17:43 ` Michael Chan
2024-10-03 18:28 ` Taehee Yoo
2024-10-03 18:34 ` Andrew Lunn
2024-10-05 6:29 ` Taehee Yoo
2024-10-08 18:10 ` Jakub Kicinski
2024-10-08 19:38 ` Michael Chan
2024-10-08 19:53 ` Jakub Kicinski
2024-10-08 20:35 ` Michael Chan
2024-10-03 16:06 ` [PATCH net-next v3 2/7] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-10-08 18:19 ` Jakub Kicinski
2024-10-09 13:54 ` Taehee Yoo
2024-10-09 15:28 ` Jakub Kicinski
2024-10-09 17:47 ` Taehee Yoo
2024-10-31 17:34 ` Taehee Yoo
2024-10-31 23:56 ` Jakub Kicinski
2024-11-01 17:11 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 3/7] net: ethtool: add support for configuring tcp-data-split-thresh Taehee Yoo
2024-10-03 18:25 ` Mina Almasry
2024-10-03 19:33 ` Taehee Yoo
2024-10-04 1:47 ` Mina Almasry
2024-10-05 6:11 ` Taehee Yoo
2024-10-08 18:33 ` Jakub Kicinski
2024-10-09 14:25 ` Taehee Yoo
2024-10-09 15:46 ` Jakub Kicinski
2024-10-09 17:49 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 4/7] bnxt_en: add support for tcp-data-split-thresh ethtool command Taehee Yoo
2024-10-03 18:13 ` Brett Creeley
2024-10-03 19:13 ` Taehee Yoo
2024-10-08 18:35 ` Jakub Kicinski
2024-10-09 14:31 ` Taehee Yoo
2024-10-03 16:06 ` Taehee Yoo [this message]
2024-10-03 18:29 ` [PATCH net-next v3 5/7] net: devmem: add ring parameter filtering Mina Almasry
2024-10-04 3:57 ` Taehee Yoo
2024-10-03 18:35 ` Brett Creeley
2024-10-03 18:49 ` Mina Almasry
2024-10-08 19:28 ` Jakub Kicinski
2024-10-09 14:35 ` Taehee Yoo
2024-10-04 4:01 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 6/7] net: ethtool: " Taehee Yoo
2024-10-03 18:32 ` Mina Almasry
2024-10-03 19:35 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 7/7] bnxt_en: add support for device memory tcp Taehee Yoo
2024-10-03 18:43 ` Mina Almasry
2024-10-04 10:34 ` Taehee Yoo
2024-10-08 2:57 ` David Wei
2024-10-09 15:02 ` Taehee Yoo
2024-10-08 19:50 ` Jakub Kicinski
2024-10-09 15:37 ` Taehee Yoo
2024-10-10 0:01 ` Jakub Kicinski
2024-10-10 17:44 ` Mina Almasry
2024-10-11 1:34 ` Jakub Kicinski
2024-10-11 17:33 ` Mina Almasry
2024-10-11 23:42 ` Jason Gunthorpe
2024-10-14 22:38 ` Mina Almasry
2024-10-15 0:16 ` Jakub Kicinski
2024-10-15 1:10 ` Mina Almasry
2024-10-15 12:44 ` Jason Gunthorpe
2024-10-18 8:25 ` Mina Almasry
2024-10-19 13:55 ` Taehee Yoo
2024-10-15 14:29 ` Pavel Begunkov
2024-10-15 17:38 ` David Wei
2024-10-05 3:48 ` kernel test robot
2024-10-08 2:45 ` David Wei
2024-10-08 3:54 ` Taehee Yoo
2024-10-08 3:58 ` Taehee Yoo
2024-10-16 20:17 ` [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Stanislav Fomichev
2024-10-17 8:58 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003160620.1521626-6-ap420073@gmail.com \
--to=ap420073@gmail.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=andrew@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dw@davidwei.uk \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@nvidia.com \
--cc=kaiyuanz@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rrameshbabu@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).