From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D09360; Fri, 4 Oct 2024 00:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728000321; cv=none; b=Vu/ePtfKAtKCOhDJaEmuVpTjR02AiJ4x3xoPXbWR2MQ7wYYi3260GvHk5r72PfEKT77tCD5anlR9fgvNjebNrWtJfH8kqN/bAbxI750dz6jZFyzbYV7VoJIJGOUBzqjvCyp2Fxesov8CySWIOsNfW8T8JUMGYg/LAUesuffTKd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728000321; c=relaxed/simple; bh=+yEM14FSzR8BArfH6Kuafdug5D83cp/1opspSQcsrX4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rZrJ33M64g4q1d+ehMBeLY83NNx/yPpzOoWmc+7+K/CV9d5ZyISR8ABesb9DsRWqVH3VtrYLHkTkOSFtmBIGaC9JjU9saOW47mar3qoWzeInpr9w7/Ma9fWNSZHlH8d23sNVbKqH4BwZt3S+DSiY7PezvYJn/0D0Nu1aCdkUs64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CY893EPW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CY893EPW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC0EAC4CEC5; Fri, 4 Oct 2024 00:05:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728000320; bh=+yEM14FSzR8BArfH6Kuafdug5D83cp/1opspSQcsrX4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CY893EPWDDJFX7gRRCgurlWrALdvA4Mtc4eJfpJ5HyEH6GGX2DXzES2LtveQ3r6rC EOQxewztjNAXN5EkEi7iQfyGtUVYbSny/KkPX2xBJFtRZ1PtCQMa9+lGJB9v04tYb3 PAHiZw3Utu7RYDpYhwFGmVXDgVOrNAX1rzQ/oA/6nRTdaHoyDRkfsYgi117bIPRNk6 pHvlvfDwJy4FOon9+qg08wZv8Qw3Osu5PvcH++KFV6cTMwvw16xtXSxpys5v/DeDgL 8HrsfCHclLw5lZOGcBRLNOlpuzDtR06W1Y/XaAg3CO663vkhlalvDU2yDgCFV5+Bbo d08K5fcsjntRQ== Date: Thu, 3 Oct 2024 17:05:18 -0700 From: Jakub Kicinski To: Shradha Gupta Cc: linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Paolo Abeni , Long Li , Simon Horman , Konstantin Taranov , Souradeep Chakrabarti , Erick Archer , Pavan Chebbi , Ahmed Zaki , Colin Ian King , Shradha Gupta Subject: Re: [PATCH net-next] net: mana: Enable debugfs files for MANA device Message-ID: <20241003170518.11cd9e20@kernel.org> In-Reply-To: <1727754041-26291-1-git-send-email-shradhagupta@linux.microsoft.com> References: <1727754041-26291-1-git-send-email-shradhagupta@linux.microsoft.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 30 Sep 2024 20:40:41 -0700 Shradha Gupta wrote: > @@ -1516,6 +1519,13 @@ static int mana_gd_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > gc->bar0_va = bar0_va; > gc->dev = &pdev->dev; > > + if (gc->is_pf) { > + gc->mana_pci_debugfs = debugfs_create_dir("0", mana_debugfs_root); > + } else { > + gc->mana_pci_debugfs = debugfs_create_dir(pci_slot_name(pdev->slot), > + mana_debugfs_root); > + } no need for brackets around single statements > @@ -1619,7 +1640,29 @@ static struct pci_driver mana_driver = { > .shutdown = mana_gd_shutdown, > }; > > -module_pci_driver(mana_driver); > +static int __init mana_driver_init(void) > +{ > + int err; > + > + mana_debugfs_root = debugfs_create_dir("mana", NULL); > + > + err = pci_register_driver(&mana_driver); > + no need for empty lines between function call and its error check > + if (err) > + debugfs_remove(mana_debugfs_root); > + > + return err; > +} > + > +static void __exit mana_driver_exit(void) > +{ > + debugfs_remove(mana_debugfs_root); > + > + pci_unregister_driver(&mana_driver); > +} > + > +module_init(mana_driver_init); > +module_exit(mana_driver_exit); > > MODULE_DEVICE_TABLE(pci, mana_id_table); > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index c47266d1c7c2..255f3189f6fa 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include looks like the headers were previously alphabetically sorted. -- pw-bot: cr