From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
thepacketgeek@gmail.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, max@kutsevol.com
Subject: Re: [PATCH net-next v4 00/10] net: netconsole refactoring and warning fix
Date: Thu, 3 Oct 2024 17:29:50 -0700 [thread overview]
Message-ID: <20241003172950.65f507b8@kernel.org> (raw)
In-Reply-To: <20240930131214.3771313-1-leitao@debian.org>
On Mon, 30 Sep 2024 06:11:59 -0700 Breno Leitao wrote:
> To address these issues, the following steps were taken:
>
> * Breaking down write_ext_msg() into smaller functions with clear scopes
> * Improving readability and reasoning about the code
> * Simplifying and clarifying naming conventions
>
> Warning Fix
> -----------
>
> The warning occurred when there was insufficient buffer space to append
> userdata. While this scenario is acceptable (as userdata can be sent in a
> separate packet later), the kernel was incorrectly raising a warning. A
> one-line fix has been implemented to resolve this issue.
>
> A self-test was developed to write messages of every possible length
> This test will be submitted in a separate patchset
Makes sense in general, but why isn't the fix sent to net first,
and then once the trees converge (follow Thursday) we can apply
the refactoring and improvements on top?
The false positive warning went into 6.9 if I'm checking correctly.
next prev parent reply other threads:[~2024-10-04 0:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 13:11 [PATCH net-next v4 00/10] net: netconsole refactoring and warning fix Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 01/10] net: netconsole: remove msg_ready variable Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 02/10] net: netconsole: split send_ext_msg_udp() function Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 03/10] net: netconsole: separate fragmented message handling in send_ext_msg Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 04/10] net: netconsole: rename body to msg_body Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 05/10] net: netconsole: introduce variable to track body length Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 06/10] net: netconsole: track explicitly if msgbody was written to buffer Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 07/10] net: netconsole: extract release appending into separate function Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 08/10] net: netconsole: do not pass userdata up to the tail Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 09/10] net: netconsole: split send_msg_fragmented Breno Leitao
2024-09-30 13:12 ` [PATCH net-next v4 10/10] net: netconsole: fix wrong warning Breno Leitao
2024-10-01 8:33 ` Simon Horman
2024-10-04 0:29 ` Jakub Kicinski [this message]
2024-10-04 8:50 ` [PATCH net-next v4 00/10] net: netconsole refactoring and warning fix Breno Leitao
2024-10-04 14:30 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003172950.65f507b8@kernel.org \
--to=kuba@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).