From: Jakub Kicinski <kuba@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: <robh@kernel.org>, <jan.kiszka@siemens.com>,
<dan.carpenter@linaro.org>, <diogo.ivo@siemens.com>,
<andrew@lunn.ch>, <pabeni@redhat.com>, <edumazet@google.com>,
<davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH net] net: ti: icssg-prueth: Fix race condition for VLAN table access
Date: Thu, 3 Oct 2024 17:41:42 -0700 [thread overview]
Message-ID: <20241003174142.384e51ad@kernel.org> (raw)
In-Reply-To: <20241003105940.533921-1-danishanwar@ti.com>
On Thu, 3 Oct 2024 16:29:40 +0530 MD Danish Anwar wrote:
> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> index bba6da2e6bd8..9a33e9ed2976 100644
> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h
> @@ -296,6 +296,7 @@ struct prueth {
> bool is_switchmode_supported;
> unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
> int default_vlan;
> + spinlock_t vtbl_lock; /* Lock for vtbl in shared memory */
This needs to be kdoc, otherwise:
drivers/net/ethernet/ti/icssg/icssg_prueth.h:301: warning: Function parameter or struct member 'vtbl_lock' not described in 'prueth'
--
pw-bot: cr
next prev parent reply other threads:[~2024-10-04 0:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 10:59 [PATCH net] net: ti: icssg-prueth: Fix race condition for VLAN table access MD Danish Anwar
2024-10-04 0:41 ` Jakub Kicinski [this message]
2024-10-04 4:55 ` MD Danish Anwar
2024-10-04 10:46 ` Simon Horman
2024-10-04 20:07 ` Jakub Kicinski
2024-10-07 5:13 ` Anwar, Md Danish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241003174142.384e51ad@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).