From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <kuba@kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<jk@codeconstruct.com.au>, <kuni1840@gmail.com>,
<kuniyu@amazon.com>, <matt@codeconstruct.com.au>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>
Subject: Re: [PATCH v1 net 4/6] mctp: Handle error of rtnl_register_module().
Date: Thu, 3 Oct 2024 18:00:48 -0700 [thread overview]
Message-ID: <20241004010048.30542-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241003173928.55b74641@kernel.org>
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 3 Oct 2024 17:39:28 -0700
> On Thu, 3 Oct 2024 13:57:23 -0700 Kuniyuki Iwashima wrote:
> > Since introduced, mctp has been ignoring the returned value
> > of rtnl_register_module(), which could fail.
> >
> > Let's handle the errors by rtnl_register_module_many().
> >
> > Fixes: 583be982d934 ("mctp: Add device handling and netlink interface")
> > Fixes: 831119f88781 ("mctp: Add neighbour netlink interface")
> > Fixes: 06d2f4c583a7 ("mctp: Add netlink route management")
> > Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
>
> Build's unhappy about the section markings:
>
> WARNING: modpost: vmlinux: section mismatch in reference: mctp_init+0xb7 (section: .init.text) -> mctp_neigh_exit (section: .exit.text)
Thanks for catching, will remove __exit from mctp_neigh_exit().
BTW what option is needed to reproduce it ?
I tried W=1 C=1 but didn't see that warning.
next prev parent reply other threads:[~2024-10-04 1:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 20:57 [PATCH v1 net 0/6] rtnetlink: Handle error of rtnl_register_module() Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 1/6] rtnetlink: Add bulk registration helpers for rtnetlink message handlers Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 2/6] vxlan: Handle error of rtnl_register_module() Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 3/6] bridge: " Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 4/6] mctp: " Kuniyuki Iwashima
2024-10-04 0:39 ` Jakub Kicinski
2024-10-04 1:00 ` Kuniyuki Iwashima [this message]
2024-10-04 16:06 ` Jakub Kicinski
2024-10-04 19:49 ` Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 5/6] mpls: " Kuniyuki Iwashima
2024-10-03 20:57 ` [PATCH v1 net 6/6] phonet: " Kuniyuki Iwashima
2024-10-04 7:12 ` Rémi Denis-Courmont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004010048.30542-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).