Re: [PATCH net v2] net: dsa: lan9303: ensure chip reset and wait for READY status

[Vladimir Oltean <olteanv@gmail.com>]

On Fri, Oct 04, 2024 at 07:26:21AM +0000, Sverdlin, Alexander wrote:
> Thanks for the review Vladimir!
> 
> On Fri, 2024-10-04 at 00:15 +0300, Vladimir Oltean wrote:
> > > +	 * switch's reading of EEPROM right after reset and this behaviour is
> > > +	 * not configurable. While lan9303_read() already has quite long retry
> > > +	 * timeout, seems not all cases are being detected as arbitration error.
> > 
> > These arbitration errors happen only after reset? So in theory, after
> > this patch, we could remove the for() loop from lan9303_read()?
> 
> This is a good point! Shall I add the removal to a series for net or post the
> removal separately for net-next?

That would be net-next material, as long as they don't intersect functionally.
What you could do is confirm that this is the case indeed, and that
nothing needs to change in the read_poll_timeout() logic even with the
simplified lan9303_read().

If true, lan9303_read() will always return 0 at the first iteration
after this patch, and after the read_poll_timeout() breaks through.