From: Vladimir Oltean <olteanv@gmail.com>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: netdev@vger.kernel.org, Anatolij Gustschin <agust@denx.de>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for READY status
Date: Fri, 4 Oct 2024 14:57:12 +0300 [thread overview]
Message-ID: <20241004115712.taqv5oolktcfhvak@skbuf> (raw)
In-Reply-To: <20241004113655.3436296-1-alexander.sverdlin@siemens.com>
On Fri, Oct 04, 2024 at 01:36:54PM +0200, A. Sverdlin wrote:
> From: Anatolij Gustschin <agust@denx.de>
>
> Accessing device registers seems to be not reliable, the chip
> revision is sometimes detected wrongly (0 instead of expected 1).
>
> Ensure that the chip reset is performed via reset GPIO and then
> wait for 'Device Ready' status in HW_CFG register before doing
> any register initializations.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> [alex: reworked using read_poll_timeout()]
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
I see you're missing a Fixes: tag (meaning in this case: backport down
to all stable tree containing this commit). I think you can just post it
as a reply to this email, without resending, and it should get picked up
by maintainers through the same mechanism as Reviewed-by: tags.
next prev parent reply other threads:[~2024-10-04 11:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 11:36 [PATCH net v4] net: dsa: lan9303: ensure chip reset and wait for READY status A. Sverdlin
2024-10-04 11:57 ` Vladimir Oltean [this message]
2024-10-04 12:07 ` Sverdlin, Alexander
2024-10-08 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004115712.taqv5oolktcfhvak@skbuf \
--to=olteanv@gmail.com \
--cc=agust@denx.de \
--cc=alexander.sverdlin@siemens.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox