From: Simon Horman <horms@kernel.org>
To: Karol Kolacinski <karol.kolacinski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com
Subject: Re: [PATCH iwl-next] ice: Add in/out PTP pin delays
Date: Fri, 4 Oct 2024 13:33:40 +0100 [thread overview]
Message-ID: <20241004123340.GH1310185@kernel.org> (raw)
In-Reply-To: <20241004064733.1362850-2-karol.kolacinski@intel.com>
On Fri, Oct 04, 2024 at 08:47:13AM +0200, Karol Kolacinski wrote:
> HW can have different input/output delays for each of the pins.
> Add a field in ice_ptp_pin_desc structure to reflect that.
>
> Implement external timestamp delay compensation.
>
> Remove existing definitions and wrappers for periodic output propagation
> delays.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
...
> @@ -1767,6 +1778,7 @@ static int ice_ptp_write_perout(struct ice_hw *hw, unsigned int chan,
> static int ice_ptp_cfg_perout(struct ice_pf *pf, struct ptp_perout_request *rq,
> int on)
> {
> + unsigned int gpio_pin, prop_delay;
> u64 clk, period, start, phase;
> struct ice_hw *hw = &pf->hw;
> unsigned int gpio_pin;
The local variable gpio_pin is now declared twice :(
next prev parent reply other threads:[~2024-10-04 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 6:47 [PATCH iwl-next] ice: Add in/out PTP pin delays Karol Kolacinski
2024-10-04 12:33 ` Simon Horman [this message]
2024-10-05 6:54 ` kernel test robot
2024-10-05 6:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004123340.GH1310185@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=karol.kolacinski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).