From: Jakub Kicinski <kuba@kernel.org>
To: Tarun Alle <tarun.alle@microchip.com>
Cc: <arun.ramadoss@microchip.com>, <UNGLinuxDriver@microchip.com>,
<andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5] net: phy: microchip_t1: SQI support for LAN887x
Date: Fri, 4 Oct 2024 16:21:41 -0700 [thread overview]
Message-ID: <20241004162141.261d2dbd@kernel.org> (raw)
In-Reply-To: <20241003162118.232123-1-tarun.alle@microchip.com>
On Thu, 3 Oct 2024 21:51:18 +0530 Tarun Alle wrote:
> + if (phydev->speed != SPEED_1000 &&
> + phydev->speed != SPEED_100) {
> + return -ENETDOWN;
> + }
Patch no longer applies, probably because of commit 5fad1c1a09ac ("net:
phy: microchip_t1: Interrupt support for lan887x"). Please rebase and repost.
When you do perhaps drop the unnecessary brackets around the single
statement in the quoted chunk?
--
pw-bot: cr
prev parent reply other threads:[~2024-10-04 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:21 [PATCH net-next v5] net: phy: microchip_t1: SQI support for LAN887x Tarun Alle
2024-10-04 20:43 ` Andrew Lunn
2024-10-04 23:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004162141.261d2dbd@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tarun.alle@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).