From: Mohammed Anees <pvmohammedanees2003@gmail.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Mohammed Anees <pvmohammedanees2003@gmail.com>
Subject: [PATCH] net: dsa: Fix conditional handling of Wake-on-Lan configuration in dsa_user_set_wol
Date: Sat, 5 Oct 2024 03:32:06 +0530 [thread overview]
Message-ID: <20241004220206.7576-1-pvmohammedanees2003@gmail.com> (raw)
The WOL configuration now checks if the DSA switch supports setting WOL
before attempting to apply settings via phylink. This prevents
unnecessary calls to phylink_ethtool_set_wol when WOL is not supported.
Signed-off-by: Mohammed Anees <pvmohammedanees2003@gmail.com>
---
net/dsa/user.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/dsa/user.c b/net/dsa/user.c
index 74eda9b30608..c685ccea9ddf 100644
--- a/net/dsa/user.c
+++ b/net/dsa/user.c
@@ -1217,10 +1217,12 @@ static int dsa_user_set_wol(struct net_device *dev, struct ethtool_wolinfo *w)
struct dsa_switch *ds = dp->ds;
int ret = -EOPNOTSUPP;
- phylink_ethtool_set_wol(dp->pl, w);
-
- if (ds->ops->set_wol)
+ if (ds->ops->set_wol) {
ret = ds->ops->set_wol(ds, dp->index, w);
+ if (ret)
+ return ret;
+ phylink_ethtool_set_wol(dp->pl, w);
+ }
return ret;
}
--
2.46.0
next reply other threads:[~2024-10-04 22:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 22:02 Mohammed Anees [this message]
2024-10-05 16:49 ` [PATCH] net: dsa: Fix conditional handling of Wake-on-Lan configuration in dsa_user_set_wol Andrew Lunn
2024-10-05 18:42 ` Mohammed Anees
2024-10-05 21:00 ` Andrew Lunn
2024-10-06 16:10 ` Mohammed Anees
2024-10-06 19:57 ` Andrew Lunn
2024-10-06 22:41 ` Mohammed Anees
2024-10-07 8:56 ` Russell King (Oracle)
2024-10-07 22:22 ` Mohammed Anees
-- strict thread matches above, loose matches on Subject: below --
2024-10-07 22:22 [PATCH v2] " Vladimir Oltean
2024-10-07 22:43 ` [PATCH] " Mohammed Anees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004220206.7576-1-pvmohammedanees2003@gmail.com \
--to=pvmohammedanees2003@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).