From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <edumazet@google.com>
Cc: <alexandre.ferrieux@orange.com>, <davem@davemloft.net>,
<dsahern@kernel.org>, <eric.dumazet@gmail.com>, <kuba@kernel.org>,
<kuniyu@amazon.com>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH net-next 3/4] ipv4: remove fib_info_lock
Date: Fri, 4 Oct 2024 15:41:35 -0700 [thread overview]
Message-ID: <20241004224135.81826-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20241004134720.579244-4-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Fri, 4 Oct 2024 13:47:19 +0000
> After the prior patch, fib_info_lock became redundant
> because all of its users are holding RTNL.
>
> BH protection is not needed.
>
> Remove the READ_ONCE()/WRITE_ONCE() annotations around fib_info_cnt,
> since it is protected by RTNL.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2024-10-04 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 13:47 [PATCH net-next 0/4] ipv4: preliminary work for per-netns RTNL Eric Dumazet
2024-10-04 13:47 ` [PATCH net-next 1/4] ipv4: remove fib_devindex_hashfn() Eric Dumazet
2024-10-04 22:32 ` Kuniyuki Iwashima
2024-10-04 13:47 ` [PATCH net-next 2/4] ipv4: use rcu in ip_fib_check_default() Eric Dumazet
2024-10-04 22:39 ` Kuniyuki Iwashima
2024-10-04 13:47 ` [PATCH net-next 3/4] ipv4: remove fib_info_lock Eric Dumazet
2024-10-04 22:41 ` Kuniyuki Iwashima [this message]
2024-10-04 13:47 ` [PATCH net-next 4/4] ipv4: remove fib_info_devhash[] Eric Dumazet
2024-10-04 22:45 ` Kuniyuki Iwashima
2024-10-07 14:08 ` Simon Horman
2024-10-07 14:13 ` Eric Dumazet
2024-10-04 14:35 ` [PATCH net-next 0/4] ipv4: preliminary work for per-netns RTNL David Ahern
2024-10-08 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004224135.81826-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alexandre.ferrieux@orange.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).