* Re: [PATCH] selftests: make kselftest-clean remove libynl outputs
2024-10-05 21:56 [PATCH] selftests: make kselftest-clean remove libynl outputs Greg Thelen
@ 2024-10-06 17:41 ` Muhammad Usama Anjum
2024-10-08 5:05 ` Guenter Roeck
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2024-10-06 17:41 UTC (permalink / raw)
To: Greg Thelen, Shuah Khan, Mina Almasry
Cc: Usama.Anjum, netdev, linux-kselftest, linux-kernel
On 10/6/24 2:56 AM, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@google.com>
> ---
> tools/testing/selftests/net/ynl.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/selftests/net/ynl.mk b/tools/testing/selftests/net/ynl.mk
> index 59cb26cf3f73..1ef24119def0 100644
> --- a/tools/testing/selftests/net/ynl.mk
> +++ b/tools/testing/selftests/net/ynl.mk
> @@ -19,3 +19,7 @@ $(YNL_OUTPUTS): CFLAGS += \
> $(OUTPUT)/libynl.a:
> $(Q)$(MAKE) -C $(top_srcdir)/tools/net/ynl GENS="$(YNL_GENS)" libynl.a
> $(Q)cp $(top_srcdir)/tools/net/ynl/libynl.a $(OUTPUT)/libynl.a
> +
> +EXTRA_CLEAN += \
> + $(top_srcdir)/tools/net/ynl/lib/__pycache__ \
> + $(top_srcdir)/tools/net/ynl/lib/*.[ado]
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] selftests: make kselftest-clean remove libynl outputs
2024-10-05 21:56 [PATCH] selftests: make kselftest-clean remove libynl outputs Greg Thelen
2024-10-06 17:41 ` Muhammad Usama Anjum
@ 2024-10-08 5:05 ` Guenter Roeck
2024-10-08 17:10 ` patchwork-bot+netdevbpf
2024-10-08 17:37 ` Mina Almasry
3 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2024-10-08 5:05 UTC (permalink / raw)
To: Greg Thelen
Cc: Shuah Khan, Mina Almasry, netdev, linux-kselftest, linux-kernel
On Sat, Oct 05, 2024 at 02:56:00PM -0700, Greg Thelen wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
> Signed-off-by: Greg Thelen <gthelen@google.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] selftests: make kselftest-clean remove libynl outputs
2024-10-05 21:56 [PATCH] selftests: make kselftest-clean remove libynl outputs Greg Thelen
2024-10-06 17:41 ` Muhammad Usama Anjum
2024-10-08 5:05 ` Guenter Roeck
@ 2024-10-08 17:10 ` patchwork-bot+netdevbpf
2024-10-08 17:37 ` Mina Almasry
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-08 17:10 UTC (permalink / raw)
To: Greg Thelen; +Cc: shuah, almasrymina, netdev, linux-kselftest, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 5 Oct 2024 14:56:00 -0700 you wrote:
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> [...]
Here is the summary with links:
- selftests: make kselftest-clean remove libynl outputs
https://git.kernel.org/netdev/net/c/1fd9e4f25782
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] selftests: make kselftest-clean remove libynl outputs
2024-10-05 21:56 [PATCH] selftests: make kselftest-clean remove libynl outputs Greg Thelen
` (2 preceding siblings ...)
2024-10-08 17:10 ` patchwork-bot+netdevbpf
@ 2024-10-08 17:37 ` Mina Almasry
3 siblings, 0 replies; 5+ messages in thread
From: Mina Almasry @ 2024-10-08 17:37 UTC (permalink / raw)
To: Greg Thelen; +Cc: Shuah Khan, netdev, linux-kselftest, linux-kernel
On Sat, Oct 5, 2024 at 2:56 PM Greg Thelen <gthelen@google.com> wrote:
>
> Starting with 6.12 commit 85585b4bc8d8 ("selftests: add ncdevmem, netcat
> for devmem TCP") kselftest-all creates additional outputs that
> kselftest-clean does not cleanup:
> $ make defconfig
> $ make kselftest-all
> $ make kselftest-clean
> $ git clean -ndxf | grep tools/net
> Would remove tools/net/ynl/lib/__pycache__/
> Would remove tools/net/ynl/lib/ynl.a
> Would remove tools/net/ynl/lib/ynl.d
> Would remove tools/net/ynl/lib/ynl.o
>
> Make kselftest-clean remove the newly added net/ynl outputs.
>
> Fixes: 85585b4bc8d8 ("selftests: add ncdevmem, netcat for devmem TCP")
Probably moot since this is merged already (sorry for the delay), but
likely it's:
Fixes: 07c3cc51a085 ("tools: net: package libynl for use in selftests")
The referenced patch doesn't touch ynl.mk, but adds a dependency on it
> Signed-off-by: Greg Thelen <gthelen@google.com>
Thank you Greg,
Reviewed-by: Mina Almasry <almasrymina@google.com>
--
Thanks,
Mina
^ permalink raw reply [flat|nested] 5+ messages in thread