From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
jacob.e.keller@intel.com, horms@kernel.org, sd@queasysnail.net,
chunkeey@gmail.com
Subject: [PATCH net-next 02/14] net: ibm: emac: tah: use devm for mutex_init
Date: Sat, 5 Oct 2024 19:28:32 -0700 [thread overview]
Message-ID: <20241006022844.1041039-3-rosenp@gmail.com> (raw)
In-Reply-To: <20241006022844.1041039-1-rosenp@gmail.com>
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/ibm/emac/tah.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/emac/tah.c b/drivers/net/ethernet/ibm/emac/tah.c
index 03e0a4445569..61f70066acb0 100644
--- a/drivers/net/ethernet/ibm/emac/tah.c
+++ b/drivers/net/ethernet/ibm/emac/tah.c
@@ -90,13 +90,17 @@ static int tah_probe(struct platform_device *ofdev)
struct device_node *np = ofdev->dev.of_node;
struct tah_instance *dev;
struct resource regs;
+ int err;
dev = devm_kzalloc(&ofdev->dev, sizeof(struct tah_instance),
GFP_KERNEL);
if (!dev)
return -ENOMEM;
- mutex_init(&dev->lock);
+ err = devm_mutex_init(&ofdev->dev, &dev->lock);
+ if (err)
+ return err;
+
dev->ofdev = ofdev;
if (of_address_to_resource(np, 0, ®s)) {
--
2.46.2
next prev parent reply other threads:[~2024-10-06 2:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 2:28 [PATCH net-next 00/14] ibm: emac: cleanup modules Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 01/14] net: ibm: emac: tah: use devm for kzalloc Rosen Penev
2024-10-06 2:28 ` Rosen Penev [this message]
2024-10-06 2:28 ` [PATCH net-next 03/14] net: ibm: emac: tah: devm_platform_get_resources Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 04/14] net: ibm: emac: rgmii: use devm for kzalloc Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 05/14] net: ibm: emac: rgmii: use devm for mutex_init Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 06/14] net: ibm: emac: rgmii: devm_platform_get_resource Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 07/14] net: ibm: emac: zmii: use devm for kzalloc Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 08/14] net: ibm: emac: zmii: use devm for mutex_init Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 09/14] net: ibm: emac: zmii: devm_platform_get_resource Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 10/14] net: ibm: emac: mal: use devm for kzalloc Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 11/14] net: ibm: emac: mal: use devm for request_irq Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 12/14] net: ibm: emac: mal: move irq maps down Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 13/14] net: ibm: emac: mal: add dcr_unmap to _remove Rosen Penev
2024-10-06 2:28 ` [PATCH net-next 14/14] net: ibm: emac: mal: move dcr map down Rosen Penev
2024-10-07 14:31 ` [PATCH net-next 00/14] ibm: emac: cleanup modules Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241006022844.1041039-3-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).