* [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag
@ 2024-10-07 0:46 linux
2024-10-08 16:37 ` Simon Horman
2024-10-08 23:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-10-07 0:46 UTC (permalink / raw)
To: ayush.sawal, davem, edumazet, kuba, pabeni, netdev
Cc: linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
chtls_set_tcb_tflag() has been unused since 2021's commit
827d329105bf ("chtls: Remove invalid set_tcb call")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h | 1 -
.../net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c | 9 ---------
2 files changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h
index 7ff82b6778ba..21e0dfeff158 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h
+++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls.h
@@ -573,7 +573,6 @@ int send_tx_flowc_wr(struct sock *sk, int compl,
u32 snd_nxt, u32 rcv_nxt);
void chtls_tcp_push(struct sock *sk, int flags);
int chtls_push_frames(struct chtls_sock *csk, int comp);
-int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val);
void chtls_set_tcb_field_rpl_skb(struct sock *sk, u16 word,
u64 mask, u64 val, u8 cookie,
int through_l2t);
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c
index 1e67140b0f80..fab6df21f01c 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_hw.c
@@ -106,15 +106,6 @@ void chtls_set_tcb_field_rpl_skb(struct sock *sk, u16 word,
send_or_defer(sk, tcp_sk(sk), skb, through_l2t);
}
-/*
- * Set one of the t_flags bits in the TCB.
- */
-int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val)
-{
- return chtls_set_tcb_field(sk, 1, 1ULL << bit_pos,
- (u64)val << bit_pos);
-}
-
static int chtls_set_tcb_keyid(struct sock *sk, int keyid)
{
return chtls_set_tcb_field(sk, 31, 0xFFFFFFFFULL, keyid);
--
2.46.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag
2024-10-07 0:46 [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag linux
@ 2024-10-08 16:37 ` Simon Horman
2024-10-08 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-10-08 16:37 UTC (permalink / raw)
To: linux; +Cc: ayush.sawal, davem, edumazet, kuba, pabeni, netdev, linux-kernel
On Mon, Oct 07, 2024 at 01:46:52AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> chtls_set_tcb_tflag() has been unused since 2021's commit
> 827d329105bf ("chtls: Remove invalid set_tcb call")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag
2024-10-07 0:46 [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag linux
2024-10-08 16:37 ` Simon Horman
@ 2024-10-08 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-08 23:20 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: ayush.sawal, davem, edumazet, kuba, pabeni, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 7 Oct 2024 01:46:52 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> chtls_set_tcb_tflag() has been unused since 2021's commit
> 827d329105bf ("chtls: Remove invalid set_tcb call")
>
> Remove it.
>
> [...]
Here is the summary with links:
- [net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag
https://git.kernel.org/netdev/net-next/c/35213cfeefa5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-08 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 0:46 [PATCH net-next] chelsio/chtls: Remove unused chtls_set_tcb_tflag linux
2024-10-08 16:37 ` Simon Horman
2024-10-08 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).