From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Lennart Franzen <lennart@lfdomain.com>,
Alexandru Tachici <alexandru.tachici@analog.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net] net: ethernet: adi: adin1110: Fix some error handling path in adin1110_read_fifo()
Date: Mon, 7 Oct 2024 16:46:00 +0100 [thread overview]
Message-ID: <20241007154600.GH32733@kernel.org> (raw)
In-Reply-To: <20241004110952.545402d0@kernel.org>
On Fri, Oct 04, 2024 at 11:09:52AM -0700, Jakub Kicinski wrote:
> On Fri, 4 Oct 2024 14:47:22 +0300 Dan Carpenter wrote:
> > It's a pity that deliberately doing a "return ret;" when ret is zero is so
> > common. Someone explained to me that it was "done deliberately to express that
> > we were propagating the success from frob_whatever()". No no no!
>
> FWIW I pitched to Linus that we should have a err_t of some sort for
> int variables which must never be returned with value of 0.
> He wasn't impressed, but I still think it would be useful :)
FWIIW, I think something like that would be quite nice.
next prev parent reply other threads:[~2024-10-07 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 18:53 [PATCH net] net: ethernet: adi: adin1110: Fix some error handling path in adin1110_read_fifo() Christophe JAILLET
2024-10-04 11:37 ` Simon Horman
2024-10-04 13:15 ` Christophe JAILLET
2024-10-07 15:45 ` Simon Horman
2024-10-04 11:47 ` Dan Carpenter
2024-10-04 13:27 ` Christophe JAILLET
2024-10-04 18:09 ` Jakub Kicinski
2024-10-07 15:46 ` Simon Horman [this message]
2024-10-07 17:35 ` Julia Lawall
2024-10-08 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007154600.GH32733@kernel.org \
--to=horms@kernel.org \
--cc=alexandru.tachici@analog.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lennart@lfdomain.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).