From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH v2 net-next 0/5] tcp: add skb->sk to more control packets
Date: Mon, 7 Oct 2024 16:28:44 -0700 [thread overview]
Message-ID: <20241007162844.7114835b@kernel.org> (raw)
In-Reply-To: <20241006203224.1404384-1-edumazet@google.com>
On Sun, 6 Oct 2024 20:32:19 +0000 Eric Dumazet wrote:
> Currently, TCP can set skb->sk for a variety of transmit packets.
>
> However, packets sent on behalf of a TIME_WAIT sockets do not
> have an attached socket.
>
> Same issue for RST packets.
>
> We want to change this, in order to increase eBPF program
> capabilities.
>
> This is slightly risky, because various layers could
> be confused by TIME_WAIT sockets showing up in skb->sk.
>
> v2: audited all sk_to_full_sk() users and addressed Martin feedback.
I think this patch set is causing crashes like:
https://netdev-3.bots.linux.dev/vmksft-nf-dbg/results/804862/2-conntrack-vrf-sh/stderr
I haven't had the time to investigate in depth and before the next run
someone else posted a broken change, sigh.
prev parent reply other threads:[~2024-10-07 23:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 20:32 [PATCH v2 net-next 0/5] tcp: add skb->sk to more control packets Eric Dumazet
2024-10-06 20:32 ` [PATCH v2 net-next 1/5] net: add TIME_WAIT logic to sk_to_full_sk() Eric Dumazet
2024-10-06 20:32 ` [PATCH v2 net-next 2/5] net_sched: sch_fq: prepare for TIME_WAIT sockets Eric Dumazet
2024-10-06 20:32 ` [PATCH v2 net-next 3/5] net: add skb_set_owner_edemux() helper Eric Dumazet
2024-10-06 20:32 ` [PATCH v2 net-next 4/5] ipv6: tcp: give socket pointer to control skbs Eric Dumazet
2024-10-06 20:32 ` [PATCH v2 net-next 5/5] ipv4: " Eric Dumazet
2024-10-07 23:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007162844.7114835b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).