* [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
@ 2024-10-07 20:39 Rosen Penev
2024-10-07 22:30 ` Keller, Jacob E
2024-10-08 0:21 ` Jakub Kicinski
0 siblings, 2 replies; 4+ messages in thread
From: Rosen Penev @ 2024-10-07 20:39 UTC (permalink / raw)
To: netdev
Cc: andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
It's done in probe so it should be done in remove.
Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/ibm/emac/mal.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c
index 1e1860ddc363..b1a32070f03a 100644
--- a/drivers/net/ethernet/ibm/emac/mal.c
+++ b/drivers/net/ethernet/ibm/emac/mal.c
@@ -715,6 +715,8 @@ static void mal_remove(struct platform_device *ofdev)
free_netdev(mal->dummy_dev);
+ dcr_unmap(mal->dcr_host, 0x100);
+
dma_free_coherent(&ofdev->dev,
sizeof(struct mal_descriptor) *
(NUM_TX_BUFF * mal->num_tx_chans +
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
2024-10-07 20:39 [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove Rosen Penev
@ 2024-10-07 22:30 ` Keller, Jacob E
2024-10-08 0:21 ` Jakub Kicinski
1 sibling, 0 replies; 4+ messages in thread
From: Keller, Jacob E @ 2024-10-07 22:30 UTC (permalink / raw)
To: Rosen Penev, netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
horms@kernel.org, sd@queasysnail.net, chunkeey@gmail.com
> -----Original Message-----
> From: Rosen Penev <rosenp@gmail.com>
> Sent: Monday, October 7, 2024 1:39 PM
> To: netdev@vger.kernel.org
> Cc: andrew@lunn.ch; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; linux-kernel@vger.kernel.org; Keller,
> Jacob E <jacob.e.keller@intel.com>; horms@kernel.org; sd@queasysnail.net;
> chunkeey@gmail.com
> Subject: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
>
> It's done in probe so it should be done in remove.
>
> Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/ibm/emac/mal.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/ibm/emac/mal.c
> b/drivers/net/ethernet/ibm/emac/mal.c
> index 1e1860ddc363..b1a32070f03a 100644
> --- a/drivers/net/ethernet/ibm/emac/mal.c
> +++ b/drivers/net/ethernet/ibm/emac/mal.c
> @@ -715,6 +715,8 @@ static void mal_remove(struct platform_device *ofdev)
>
> free_netdev(mal->dummy_dev);
>
> + dcr_unmap(mal->dcr_host, 0x100);
> +
> dma_free_coherent(&ofdev->dev,
> sizeof(struct mal_descriptor) *
> (NUM_TX_BUFF * mal->num_tx_chans +
> --
> 2.46.2
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
2024-10-07 20:39 [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove Rosen Penev
2024-10-07 22:30 ` Keller, Jacob E
@ 2024-10-08 0:21 ` Jakub Kicinski
2024-10-08 0:46 ` Jakub Kicinski
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2024-10-08 0:21 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew, davem, edumazet, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
On Mon, 7 Oct 2024 13:39:23 -0700 Rosen Penev wrote:
> Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
I'll fix this one when applying but please make sure there is no empty
lines between tags in the future.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove
2024-10-08 0:21 ` Jakub Kicinski
@ 2024-10-08 0:46 ` Jakub Kicinski
0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-10-08 0:46 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew, davem, edumazet, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
On Mon, 7 Oct 2024 17:21:22 -0700 Jakub Kicinski wrote:
> On Mon, 7 Oct 2024 13:39:23 -0700 Rosen Penev wrote:
> > Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> I'll fix this one when applying but please make sure there is no empty
> lines between tags in the future.
I take that back, 'cause it also doesn't apply
--
pw-bot: cr
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-08 0:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 20:39 [PATCH net] net: ibm: emac: mal: add dcr_unmap to _remove Rosen Penev
2024-10-07 22:30 ` Keller, Jacob E
2024-10-08 0:21 ` Jakub Kicinski
2024-10-08 0:46 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).