From: Mohammed Anees <pvmohammedanees2003@gmail.com>
To: linux@armlinux.org.uk
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
f.fainelli@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
olteanv@gmail.com, pabeni@redhat.com,
pvmohammedanees2003@gmail.com
Subject: Re: [PATCH] net: dsa: Fix conditional handling of Wake-on-Lan configuration in dsa_user_set_wol
Date: Tue, 8 Oct 2024 03:52:59 +0530 [thread overview]
Message-ID: <20241007222301.2622-1-pvmohammedanees2003@gmail.com> (raw)
In-Reply-To: <ZwOiNQSNJ7CzqbO1@shell.armlinux.org.uk>
Apologies for overlooking the previous code. Based on your
suggestion, I’ve refined the implementation. Below is the
final version, please let me know if this works, and I’ll
send a new patch.
int phy_ret, mac_ret = -EOPNOTSUPP;
phy_ret = phylink_ethtool_set_wol(dp->pl, w);
if (phy_ret != 0 && phy_ret != -EOPNOTSUPP)
return phy_ret;
if (ds->ops->set_wol) {
mac_ret = ds->ops->set_wol(ds, dp->index, w);
if (mac_ret != 0 && mac_ret != -EOPNOTSUPP)
return mac_ret;
}
// Return success if either PHY or MAC succeeded
if (phy_ret == 0 || mac_ret == 0)
return 0;
return -EOPNOTSUPP;
Thanks!
next prev parent reply other threads:[~2024-10-07 22:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 22:02 [PATCH] net: dsa: Fix conditional handling of Wake-on-Lan configuration in dsa_user_set_wol Mohammed Anees
2024-10-05 16:49 ` Andrew Lunn
2024-10-05 18:42 ` Mohammed Anees
2024-10-05 21:00 ` Andrew Lunn
2024-10-06 16:10 ` Mohammed Anees
2024-10-06 19:57 ` Andrew Lunn
2024-10-06 22:41 ` Mohammed Anees
2024-10-07 8:56 ` Russell King (Oracle)
2024-10-07 22:22 ` Mohammed Anees [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-07 22:22 [PATCH v2] " Vladimir Oltean
2024-10-07 22:43 ` [PATCH] " Mohammed Anees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007222301.2622-1-pvmohammedanees2003@gmail.com \
--to=pvmohammedanees2003@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).