* [PATCH net] net: ibm: emac: mal: fix wrong goto
@ 2024-10-07 23:57 Rosen Penev
2024-10-08 15:25 ` Markus Elfring
2024-10-09 1:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Rosen Penev @ 2024-10-07 23:57 UTC (permalink / raw)
To: netdev
Cc: andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
dcr_map is called in the previous if and therefore needs to be unmapped.
Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/ibm/emac/mal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c
index d92dd9c83031..0c5e22d14372 100644
--- a/drivers/net/ethernet/ibm/emac/mal.c
+++ b/drivers/net/ethernet/ibm/emac/mal.c
@@ -578,7 +578,7 @@ static int mal_probe(struct platform_device *ofdev)
printk(KERN_ERR "%pOF: Support for 405EZ not enabled!\n",
ofdev->dev.of_node);
err = -ENODEV;
- goto fail;
+ goto fail_unmap;
#endif
}
--
2.46.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: ibm: emac: mal: fix wrong goto
2024-10-07 23:57 [PATCH net] net: ibm: emac: mal: fix wrong goto Rosen Penev
@ 2024-10-08 15:25 ` Markus Elfring
2024-10-09 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-10-08 15:25 UTC (permalink / raw)
To: Rosen Penev, netdev, Andrew Lunn, Christian Lamparter,
David S. Miller, Eric Dumazet, Jacob Keller, Jakub Kicinski,
Paolo Abeni, Sabrina Dubroca, Simon Horman
Cc: LKML
> dcr_map is called in the previous if and therefore needs to be unmapped.
How do you think about to choose an additional imperative wording
for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: ibm: emac: mal: fix wrong goto
2024-10-07 23:57 [PATCH net] net: ibm: emac: mal: fix wrong goto Rosen Penev
2024-10-08 15:25 ` Markus Elfring
@ 2024-10-09 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-10-09 1:30 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew, davem, edumazet, kuba, pabeni, linux-kernel,
jacob.e.keller, horms, sd, chunkeey
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 7 Oct 2024 16:57:11 -0700 you wrote:
> dcr_map is called in the previous if and therefore needs to be unmapped.
>
> Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/ibm/emac/mal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net] net: ibm: emac: mal: fix wrong goto
https://git.kernel.org/netdev/net/c/08c8acc9d8f3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 23:57 [PATCH net] net: ibm: emac: mal: fix wrong goto Rosen Penev
2024-10-08 15:25 ` Markus Elfring
2024-10-09 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).