From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: Taehee Yoo <ap420073@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
almasrymina@google.com, netdev@vger.kernel.org,
linux-doc@vger.kernel.org, donald.hunter@gmail.com,
corbet@lwn.net, kory.maincent@bootlin.com,
maxime.chevallier@bootlin.com, danieller@nvidia.com,
hengqi@linux.alibaba.com, ecree.xilinx@gmail.com,
przemyslaw.kitszel@intel.com, hkallweit1@gmail.com,
ahmed.zaki@intel.com, paul.greenwalt@intel.com,
rrameshbabu@nvidia.com, idosch@nvidia.com,
asml.silence@gmail.com, kaiyuanz@google.com, willemb@google.com,
aleksander.lobakin@intel.com, dw@davidwei.uk,
sridhar.samudrala@intel.com, bcreeley@amd.com
Subject: Re: [PATCH net-next v3 1/7] bnxt_en: add support for rx-copybreak ethtool command
Date: Tue, 8 Oct 2024 12:53:26 -0700 [thread overview]
Message-ID: <20241008125326.2e17dce9@kernel.org> (raw)
In-Reply-To: <CACKFLikDqgewWCutDG9ar6UFup_EUefUEaXShEg0kmxC5yiHMg@mail.gmail.com>
On Tue, 8 Oct 2024 12:38:18 -0700 Michael Chan wrote:
> > Where does the min value of 64 come from? Ethernet min frame length?
>
> The length is actually the ethernet length minus the 4-byte CRC. So
> 60 is the minimum length that the driver will see. Anything smaller
> coming from the wire will be a runt frame discarded by the chip.
Also for VF to VF traffic?
> > IIUC the copybreak threshold is purely a SW feature, after this series.
> > If someone sets the copybreak value to, say 13 it will simply never
> > engage but it's not really an invalid setting, IMHO. Similarly setting
> > it to 0 makes intuitive sense (that's how e1000e works, AFAICT).
>
> Right, setting it to 0 or 13 will have the same effect of disabling
> it. 0 makes more intuitive sense.
Agreed on 0 making sense, but not sure if rejecting intermediate values
buys us anything. As Andrew mentioned consistency is important. I only
checked two drivers (e1000e and gve) and they don't seem to check
the lower limit.
next prev parent reply other threads:[~2024-10-08 19:53 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 16:06 [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 1/7] bnxt_en: add support for rx-copybreak ethtool command Taehee Yoo
2024-10-03 16:57 ` Brett Creeley
2024-10-03 17:15 ` Taehee Yoo
2024-10-03 17:13 ` Michael Chan
2024-10-03 17:22 ` Taehee Yoo
2024-10-03 17:43 ` Michael Chan
2024-10-03 18:28 ` Taehee Yoo
2024-10-03 18:34 ` Andrew Lunn
2024-10-05 6:29 ` Taehee Yoo
2024-10-08 18:10 ` Jakub Kicinski
2024-10-08 19:38 ` Michael Chan
2024-10-08 19:53 ` Jakub Kicinski [this message]
2024-10-08 20:35 ` Michael Chan
2024-10-03 16:06 ` [PATCH net-next v3 2/7] bnxt_en: add support for tcp-data-split " Taehee Yoo
2024-10-08 18:19 ` Jakub Kicinski
2024-10-09 13:54 ` Taehee Yoo
2024-10-09 15:28 ` Jakub Kicinski
2024-10-09 17:47 ` Taehee Yoo
2024-10-31 17:34 ` Taehee Yoo
2024-10-31 23:56 ` Jakub Kicinski
2024-11-01 17:11 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 3/7] net: ethtool: add support for configuring tcp-data-split-thresh Taehee Yoo
2024-10-03 18:25 ` Mina Almasry
2024-10-03 19:33 ` Taehee Yoo
2024-10-04 1:47 ` Mina Almasry
2024-10-05 6:11 ` Taehee Yoo
2024-10-08 18:33 ` Jakub Kicinski
2024-10-09 14:25 ` Taehee Yoo
2024-10-09 15:46 ` Jakub Kicinski
2024-10-09 17:49 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 4/7] bnxt_en: add support for tcp-data-split-thresh ethtool command Taehee Yoo
2024-10-03 18:13 ` Brett Creeley
2024-10-03 19:13 ` Taehee Yoo
2024-10-08 18:35 ` Jakub Kicinski
2024-10-09 14:31 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 5/7] net: devmem: add ring parameter filtering Taehee Yoo
2024-10-03 18:29 ` Mina Almasry
2024-10-04 3:57 ` Taehee Yoo
2024-10-03 18:35 ` Brett Creeley
2024-10-03 18:49 ` Mina Almasry
2024-10-08 19:28 ` Jakub Kicinski
2024-10-09 14:35 ` Taehee Yoo
2024-10-04 4:01 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 6/7] net: ethtool: " Taehee Yoo
2024-10-03 18:32 ` Mina Almasry
2024-10-03 19:35 ` Taehee Yoo
2024-10-03 16:06 ` [PATCH net-next v3 7/7] bnxt_en: add support for device memory tcp Taehee Yoo
2024-10-03 18:43 ` Mina Almasry
2024-10-04 10:34 ` Taehee Yoo
2024-10-08 2:57 ` David Wei
2024-10-09 15:02 ` Taehee Yoo
2024-10-08 19:50 ` Jakub Kicinski
2024-10-09 15:37 ` Taehee Yoo
2024-10-10 0:01 ` Jakub Kicinski
2024-10-10 17:44 ` Mina Almasry
2024-10-11 1:34 ` Jakub Kicinski
2024-10-11 17:33 ` Mina Almasry
2024-10-11 23:42 ` Jason Gunthorpe
2024-10-14 22:38 ` Mina Almasry
2024-10-15 0:16 ` Jakub Kicinski
2024-10-15 1:10 ` Mina Almasry
2024-10-15 12:44 ` Jason Gunthorpe
2024-10-18 8:25 ` Mina Almasry
2024-10-19 13:55 ` Taehee Yoo
2024-10-15 14:29 ` Pavel Begunkov
2024-10-15 17:38 ` David Wei
2024-10-05 3:48 ` kernel test robot
2024-10-08 2:45 ` David Wei
2024-10-08 3:54 ` Taehee Yoo
2024-10-08 3:58 ` Taehee Yoo
2024-10-16 20:17 ` [PATCH net-next v3 0/7] bnxt_en: implement device memory TCP for bnxt Stanislav Fomichev
2024-10-17 8:58 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008125326.2e17dce9@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=almasrymina@google.com \
--cc=andrew@lunn.ch \
--cc=ap420073@gmail.com \
--cc=asml.silence@gmail.com \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dw@davidwei.uk \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=hkallweit1@gmail.com \
--cc=idosch@nvidia.com \
--cc=kaiyuanz@google.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rrameshbabu@nvidia.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).