From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, mkarsten@uwaterloo.ca,
skhawaja@google.com, sdf@fomichev.me, bjorn@rivosinc.com,
amritha.nambiar@intel.com, sridhar.samudrala@intel.com,
willemdebruijn.kernel@gmail.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Donald Hunter <donald.hunter@gmail.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Mina Almasry <almasrymina@google.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Daniel Jurgens <danielj@nvidia.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next v4 6/9] netdev-genl: Support setting per-NAPI config values
Date: Tue, 8 Oct 2024 15:19:34 -0700 [thread overview]
Message-ID: <20241008151934.58f124f1@kernel.org> (raw)
In-Reply-To: <ZwV3_3K_ID1Va6rT@LQ3V64L9R2>
On Tue, 8 Oct 2024 11:20:47 -0700 Joe Damato wrote:
> Noticed this while re-reading the code; planning on changing this
> from NLA_S32 to NLA_U32 for v5.
Make sure you edit the spec, not the output. Looks like there may be
a problem here (napi-id vs id in the attributes).
Make sure you run: ./tools/net/ynl/ynl-regen.sh -f
and the tree is clean afterwards
next prev parent reply other threads:[~2024-10-08 22:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 23:52 [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 1/9] net: napi: Make napi_defer_hard_irqs per-NAPI Joe Damato
2024-10-08 22:08 ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 2/9] netdev-genl: Dump napi_defer_hard_irqs Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 3/9] net: napi: Make gro_flush_timeout per-NAPI Joe Damato
2024-10-08 18:22 ` Joe Damato
2024-10-08 22:10 ` Jakub Kicinski
2024-10-01 23:52 ` [RFC net-next v4 4/9] netdev-genl: Dump gro_flush_timeout Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 5/9] net: napi: Add napi_config Joe Damato
2024-10-08 18:19 ` Joe Damato
2024-10-08 22:17 ` Jakub Kicinski
2024-10-08 22:28 ` Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 6/9] netdev-genl: Support setting per-NAPI config values Joe Damato
2024-10-08 18:20 ` Joe Damato
2024-10-08 22:19 ` Jakub Kicinski [this message]
2024-10-08 23:00 ` Joe Damato
2024-10-08 23:19 ` Jakub Kicinski
2024-10-08 23:57 ` Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 7/9] bnxt: Add support for persistent NAPI config Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 8/9] mlx5: " Joe Damato
2024-10-01 23:52 ` [RFC net-next v4 9/9] mlx4: Add support for persistent NAPI config to RX CQs Joe Damato
2024-10-03 23:29 ` [RFC net-next v4 0/9] Add support for per-NAPI config via netlink Stanislav Fomichev
2024-10-03 23:53 ` Joe Damato
2024-10-04 2:33 ` Joe Damato
2024-10-04 16:22 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008151934.58f124f1@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=amritha.nambiar@intel.com \
--cc=bjorn@rivosinc.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jdamato@fastly.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=skhawaja@google.com \
--cc=sridhar.samudrala@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).