From: Simon Horman <horms@kernel.org>
To: Dipendra Khadka <kdipendra88@gmail.com>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors
Date: Tue, 8 Oct 2024 17:19:43 +0100 [thread overview]
Message-ID: <20241008161943.GA99782@kernel.org> (raw)
In-Reply-To: <CAEKBCKMrtLm1j3dU+H12Oy8635Ra2bZ6eFfxdixTvYwSEEyaJQ@mail.gmail.com>
On Tue, Oct 08, 2024 at 09:28:18PM +0545, Dipendra Khadka wrote:
> Hi Simon,
>
> On Tue, 8 Oct 2024 at 19:05, Simon Horman <horms@kernel.org> wrote:
> >
> > On Sun, Oct 06, 2024 at 04:38:31PM +0000, Dipendra Khadka wrote:
> > > This patch series improves error handling in the Marvell OcteonTX2
> > > NIC driver. Specifically, it adds error pointer checks after
> > > otx2_mbox_get_rsp() to ensure the driver handles error cases more
> > > gracefully.
> > >
> > > Changes in v3:
> > > - Created a patch-set as per the feedback
> > > - Corrected patch subject
> > > - Added error handling in the new files
> > >
> > > Dipendra Khadka (6):
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in cn10k.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
> > >
> > > drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 5 +++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 5 +++++
> > > .../ethernet/marvell/octeontx2/nic/otx2_dmac_flt.c | 9 +++++++++
> > > .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 10 ++++++++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 12 ++++++++++++
> > > 6 files changed, 45 insertions(+)
> >
> > Thanks for bundling this up in a patch-set.
> >
> > For reference, it does seem that the threading of this patchset is broken.
> > Perhaps there was some option you passed to git send-email that caused
> > this. In any case, please look into this for future submissions.
> >
> > Also, please use ./scripts/get_maintainer.pl patch_file to generate
> > the CC list for patches.
> >
> > Lastly, b4 can help with both of the above.
>
> Sure, thanks for this.
> Do I have to send all the patches again with v4 with the new changes
> to the few patches and the same old unchanged patches?
Please send all the patches when you send a new version.
prev parent reply other threads:[~2024-10-08 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-06 16:38 [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors Dipendra Khadka
2024-10-08 13:20 ` Simon Horman
2024-10-08 15:43 ` Dipendra Khadka
2024-10-08 16:19 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008161943.GA99782@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kdipendra88@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).