* [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors
@ 2024-10-06 16:38 Dipendra Khadka
2024-10-08 13:20 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Dipendra Khadka @ 2024-10-06 16:38 UTC (permalink / raw)
To: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni
Cc: Dipendra Khadka, maxime.chevallier, horms, netdev, linux-kernel
This patch series improves error handling in the Marvell OcteonTX2
NIC driver. Specifically, it adds error pointer checks after
otx2_mbox_get_rsp() to ensure the driver handles error cases more
gracefully.
Changes in v3:
- Created a patch-set as per the feedback
- Corrected patch subject
- Added error handling in the new files
Dipendra Khadka (6):
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
octeontx2-pf: handle otx2_mbox_get_rsp errors in cn10k.c
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 5 +++++
.../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
.../net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 5 +++++
.../ethernet/marvell/octeontx2/nic/otx2_dmac_flt.c | 9 +++++++++
.../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 10 ++++++++++
.../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 12 ++++++++++++
6 files changed, 45 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors
2024-10-06 16:38 [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors Dipendra Khadka
@ 2024-10-08 13:20 ` Simon Horman
2024-10-08 15:43 ` Dipendra Khadka
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2024-10-08 13:20 UTC (permalink / raw)
To: Dipendra Khadka
Cc: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni,
maxime.chevallier, netdev, linux-kernel
On Sun, Oct 06, 2024 at 04:38:31PM +0000, Dipendra Khadka wrote:
> This patch series improves error handling in the Marvell OcteonTX2
> NIC driver. Specifically, it adds error pointer checks after
> otx2_mbox_get_rsp() to ensure the driver handles error cases more
> gracefully.
>
> Changes in v3:
> - Created a patch-set as per the feedback
> - Corrected patch subject
> - Added error handling in the new files
>
> Dipendra Khadka (6):
> octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
> octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
> octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
> octeontx2-pf: handle otx2_mbox_get_rsp errors in cn10k.c
> octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
> octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
>
> drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 5 +++++
> .../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
> .../net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 5 +++++
> .../ethernet/marvell/octeontx2/nic/otx2_dmac_flt.c | 9 +++++++++
> .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 10 ++++++++++
> .../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 12 ++++++++++++
> 6 files changed, 45 insertions(+)
Thanks for bundling this up in a patch-set.
For reference, it does seem that the threading of this patchset is broken.
Perhaps there was some option you passed to git send-email that caused
this. In any case, please look into this for future submissions.
Also, please use ./scripts/get_maintainer.pl patch_file to generate
the CC list for patches.
Lastly, b4 can help with both of the above.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors
2024-10-08 13:20 ` Simon Horman
@ 2024-10-08 15:43 ` Dipendra Khadka
2024-10-08 16:19 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Dipendra Khadka @ 2024-10-08 15:43 UTC (permalink / raw)
To: Simon Horman
Cc: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni,
maxime.chevallier, netdev, linux-kernel
Hi Simon,
On Tue, 8 Oct 2024 at 19:05, Simon Horman <horms@kernel.org> wrote:
>
> On Sun, Oct 06, 2024 at 04:38:31PM +0000, Dipendra Khadka wrote:
> > This patch series improves error handling in the Marvell OcteonTX2
> > NIC driver. Specifically, it adds error pointer checks after
> > otx2_mbox_get_rsp() to ensure the driver handles error cases more
> > gracefully.
> >
> > Changes in v3:
> > - Created a patch-set as per the feedback
> > - Corrected patch subject
> > - Added error handling in the new files
> >
> > Dipendra Khadka (6):
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in cn10k.c
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
> > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
> >
> > drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 5 +++++
> > .../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
> > .../net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 5 +++++
> > .../ethernet/marvell/octeontx2/nic/otx2_dmac_flt.c | 9 +++++++++
> > .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 10 ++++++++++
> > .../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 12 ++++++++++++
> > 6 files changed, 45 insertions(+)
>
> Thanks for bundling this up in a patch-set.
>
> For reference, it does seem that the threading of this patchset is broken.
> Perhaps there was some option you passed to git send-email that caused
> this. In any case, please look into this for future submissions.
>
> Also, please use ./scripts/get_maintainer.pl patch_file to generate
> the CC list for patches.
>
> Lastly, b4 can help with both of the above.
Sure, thanks for this.
Do I have to send all the patches again with v4 with the new changes
to the few patches and the same old unchanged patches?
Best Regard,
Dipendra Khadka
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors
2024-10-08 15:43 ` Dipendra Khadka
@ 2024-10-08 16:19 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2024-10-08 16:19 UTC (permalink / raw)
To: Dipendra Khadka
Cc: sgoutham, gakula, sbhatta, hkelam, davem, edumazet, kuba, pabeni,
maxime.chevallier, netdev, linux-kernel
On Tue, Oct 08, 2024 at 09:28:18PM +0545, Dipendra Khadka wrote:
> Hi Simon,
>
> On Tue, 8 Oct 2024 at 19:05, Simon Horman <horms@kernel.org> wrote:
> >
> > On Sun, Oct 06, 2024 at 04:38:31PM +0000, Dipendra Khadka wrote:
> > > This patch series improves error handling in the Marvell OcteonTX2
> > > NIC driver. Specifically, it adds error pointer checks after
> > > otx2_mbox_get_rsp() to ensure the driver handles error cases more
> > > gracefully.
> > >
> > > Changes in v3:
> > > - Created a patch-set as per the feedback
> > > - Corrected patch subject
> > > - Added error handling in the new files
> > >
> > > Dipendra Khadka (6):
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_ethtool.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_flows.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in cn10k.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dmac_flt.c
> > > octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_dcbnl.c
> > >
> > > drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c | 5 +++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 5 +++++
> > > .../ethernet/marvell/octeontx2/nic/otx2_dmac_flt.c | 9 +++++++++
> > > .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 10 ++++++++++
> > > .../net/ethernet/marvell/octeontx2/nic/otx2_flows.c | 12 ++++++++++++
> > > 6 files changed, 45 insertions(+)
> >
> > Thanks for bundling this up in a patch-set.
> >
> > For reference, it does seem that the threading of this patchset is broken.
> > Perhaps there was some option you passed to git send-email that caused
> > this. In any case, please look into this for future submissions.
> >
> > Also, please use ./scripts/get_maintainer.pl patch_file to generate
> > the CC list for patches.
> >
> > Lastly, b4 can help with both of the above.
>
> Sure, thanks for this.
> Do I have to send all the patches again with v4 with the new changes
> to the few patches and the same old unchanged patches?
Please send all the patches when you send a new version.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-08 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 16:38 [PATCH net v3 0/6] octeontx2-pf: handle otx2_mbox_get_rsp errors Dipendra Khadka
2024-10-08 13:20 ` Simon Horman
2024-10-08 15:43 ` Dipendra Khadka
2024-10-08 16:19 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).