From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rosen Penev" <rosenp@gmail.com>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Breno Leitao" <leitao@debian.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Jeff Garzik" <jeff@garzik.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2 net] net: ibm: emac: mal: add dcr_unmap to _remove
Date: Tue, 8 Oct 2024 16:30:50 -0700 [thread overview]
Message-ID: <20241008233050.9422-1-rosenp@gmail.com> (raw)
It's done in probe so it should be done here.
Fixes: 1d3bb996 ("Device tree aware EMAC driver")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: Rebase and add proper fixes line.
drivers/net/ethernet/ibm/emac/mal.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c
index a93423035325..c634534710d9 100644
--- a/drivers/net/ethernet/ibm/emac/mal.c
+++ b/drivers/net/ethernet/ibm/emac/mal.c
@@ -742,6 +742,8 @@ static void mal_remove(struct platform_device *ofdev)
free_netdev(mal->dummy_dev);
+ dcr_unmap(mal->dcr_host, 0x100);
+
dma_free_coherent(&ofdev->dev,
sizeof(struct mal_descriptor) *
(NUM_TX_BUFF * mal->num_tx_chans +
--
2.46.2
next reply other threads:[~2024-10-08 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 23:30 Rosen Penev [this message]
2024-10-09 8:23 ` [PATCHv2 net] net: ibm: emac: mal: add dcr_unmap to _remove Breno Leitao
2024-10-10 2:28 ` Jakub Kicinski
2024-10-10 2:53 ` Rosen Penev
2024-10-10 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241008233050.9422-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=david@gibson.dropbear.id.au \
--cc=edumazet@google.com \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_jjohnson@quicinc.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox