From: Jakub Kicinski <kuba@kernel.org>
To: Sanman Pradhan <sanman.p211993@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
kernel-team@meta.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jdelvare@suse.com, linux@roeck-us.net,
horms@kernel.org, mohsin.bashr@gmail.com, sanmanpradhan@meta.com,
andrew@lunn.ch, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH net-next v4] eth: fbnic: Add hardware monitoring support via HWMON interface
Date: Wed, 9 Oct 2024 06:26:53 -0700 [thread overview]
Message-ID: <20241009062653.79fb9c36@kernel.org> (raw)
In-Reply-To: <20241008143212.2354554-1-sanman.p211993@gmail.com>
On Tue, 8 Oct 2024 07:32:12 -0700 Sanman Pradhan wrote:
> if (!fbd->dsn) {
> dev_warn(&pdev->dev, "Reading serial number failed\n");
> - goto init_failure_mode;
> + goto hwmon_unregister;
> }
>
> netdev = fbnic_netdev_alloc(fbd);
> @@ -310,6 +312,8 @@ static int fbnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> ifm_free_netdev:
> fbnic_netdev_free(fbd);
> +hwmon_unregister:
> + fbnic_hwmon_unregister(fbd);
not what I meant...
Delete these two lines and leave the goto above as is.
HWMON can remain registered even if we don't probe networking.
--
pw-bot: cr
prev parent reply other threads:[~2024-10-09 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 14:32 [PATCH net-next v4] eth: fbnic: Add hardware monitoring support via HWMON interface Sanman Pradhan
2024-10-09 12:31 ` Simon Horman
2024-10-09 13:26 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009062653.79fb9c36@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel-team@meta.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sanman.p211993@gmail.com \
--cc=sanmanpradhan@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).