* [PATCH net-next] net: add kdoc for dev->fib_nh_head
@ 2024-10-08 9:38 Eric Dumazet
2024-10-08 9:48 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2024-10-08 9:38 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet, Simon Horman
Simon reported that fib_nh_head kdoc was missing.
Fixes: a3f5f4c2f9b6 ("ipv4: remove fib_info_devhash[]")
Closes: https://lore.kernel.org/netdev/20241007140850.GC32733@kernel.org/raw
Reported-by: Simon Horman <horms@kernel.org>
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
include/linux/netdevice.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 3baf8e539b6f33caaf83961c4cf619b799e5e41d..b5a5a2b555cda76ce2c0b3b3b2124b34409d1d69 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1842,6 +1842,7 @@ enum netdev_reg_state {
* @tipc_ptr: TIPC specific data
* @atalk_ptr: AppleTalk link
* @ip_ptr: IPv4 specific data
+ * @fib_nh_head: list of fib_nh attached to this device
* @ip6_ptr: IPv6 specific data
* @ax25_ptr: AX.25 specific data
* @ieee80211_ptr: IEEE 802.11 specific data, assign before registering
--
2.47.0.rc0.187.ge670bccf7e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: add kdoc for dev->fib_nh_head
2024-10-08 9:38 [PATCH net-next] net: add kdoc for dev->fib_nh_head Eric Dumazet
@ 2024-10-08 9:48 ` Eric Dumazet
2024-10-09 12:07 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2024-10-08 9:48 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Simon Horman
On Tue, Oct 8, 2024 at 11:38 AM Eric Dumazet <edumazet@google.com> wrote:
>
> Simon reported that fib_nh_head kdoc was missing.
>
> Fixes: a3f5f4c2f9b6 ("ipv4: remove fib_info_devhash[]")
> Closes: https://lore.kernel.org/netdev/20241007140850.GC32733@kernel.org/raw
> Reported-by: Simon Horman <horms@kernel.org>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> include/linux/netdevice.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 3baf8e539b6f33caaf83961c4cf619b799e5e41d..b5a5a2b555cda76ce2c0b3b3b2124b34409d1d69 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1842,6 +1842,7 @@ enum netdev_reg_state {
> * @tipc_ptr: TIPC specific data
> * @atalk_ptr: AppleTalk link
> * @ip_ptr: IPv4 specific data
> + * @fib_nh_head: list of fib_nh attached to this device
> * @ip6_ptr: IPv6 specific data
> * @ax25_ptr: AX.25 specific data
> * @ieee80211_ptr: IEEE 802.11 specific data, assign before registering
> --
> 2.47.0.rc0.187.ge670bccf7e-goog
>
Hmm... maybe not needed, I saw Jakub added inline:
/** @fib_nh_head: nexthops associated with this netdev */
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: add kdoc for dev->fib_nh_head
2024-10-08 9:48 ` Eric Dumazet
@ 2024-10-09 12:07 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-10-09 12:07 UTC (permalink / raw)
To: Eric Dumazet
Cc: David S . Miller, Jakub Kicinski, Paolo Abeni, netdev,
eric.dumazet
On Tue, Oct 08, 2024 at 11:48:12AM +0200, Eric Dumazet wrote:
> On Tue, Oct 8, 2024 at 11:38 AM Eric Dumazet <edumazet@google.com> wrote:
> >
> > Simon reported that fib_nh_head kdoc was missing.
> >
> > Fixes: a3f5f4c2f9b6 ("ipv4: remove fib_info_devhash[]")
> > Closes: https://lore.kernel.org/netdev/20241007140850.GC32733@kernel.org/raw
> > Reported-by: Simon Horman <horms@kernel.org>
> > Signed-off-by: Eric Dumazet <edumazet@google.com>
> > ---
> > include/linux/netdevice.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> > index 3baf8e539b6f33caaf83961c4cf619b799e5e41d..b5a5a2b555cda76ce2c0b3b3b2124b34409d1d69 100644
> > --- a/include/linux/netdevice.h
> > +++ b/include/linux/netdevice.h
> > @@ -1842,6 +1842,7 @@ enum netdev_reg_state {
> > * @tipc_ptr: TIPC specific data
> > * @atalk_ptr: AppleTalk link
> > * @ip_ptr: IPv4 specific data
> > + * @fib_nh_head: list of fib_nh attached to this device
> > * @ip6_ptr: IPv6 specific data
> > * @ax25_ptr: AX.25 specific data
> > * @ieee80211_ptr: IEEE 802.11 specific data, assign before registering
> > --
> > 2.47.0.rc0.187.ge670bccf7e-goog
> >
>
> Hmm... maybe not needed, I saw Jakub added inline:
>
> /** @fib_nh_head: nexthops associated with this netdev */
Thanks, I see that too.
Sorry for the noise.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-09 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-08 9:38 [PATCH net-next] net: add kdoc for dev->fib_nh_head Eric Dumazet
2024-10-08 9:48 ` Eric Dumazet
2024-10-09 12:07 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).