netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] net: sfp: change quirks for Alcatel Lucent G-010S-P
@ 2024-10-05 16:04 Shengyu Qu
  2024-10-10  0:40 ` Jakub Kicinski
  0 siblings, 1 reply; 3+ messages in thread
From: Shengyu Qu @ 2024-10-05 16:04 UTC (permalink / raw)
  To: linux, andrew, hkallweit1, davem, edumazet, kuba, pabeni, netdev,
	linux-kernel
  Cc: wiagn233

Seems Alcatel Lucent G-010S-P also have the same problem that it uses
TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.

Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
---
   drivers/net/phy/sfp.c | 3 ++-
   1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
index a5684ef5884bd..dcec92625cf65 100644
--- a/drivers/net/phy/sfp.c
+++ b/drivers/net/phy/sfp.c
@@ -466,7 +466,8 @@ static void sfp_quirk_ubnt_uf_instant(const struct sfp_eeprom_id *id,
   static const struct sfp_quirk sfp_quirks[] = {
          // Alcatel Lucent G-010S-P can operate at 2500base-X, but incorrectly
          // report 2500MBd NRZ in their EEPROM
-       SFP_QUIRK_M("ALCATELLUCENT", "G010SP", sfp_quirk_2500basex),
+       SFP_QUIRK("ALCATELLUCENT", "G010SP", sfp_quirk_2500basex,
+                 sfp_fixup_ignore_tx_fault),

          // Alcatel Lucent G-010S-A can operate at 2500base-X, but report 3.2GBd
          // NRZ in their EEPROM
--
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] net: sfp: change quirks for Alcatel Lucent G-010S-P
  2024-10-05 16:04 [PATCH v1] net: sfp: change quirks for Alcatel Lucent G-010S-P Shengyu Qu
@ 2024-10-10  0:40 ` Jakub Kicinski
  2024-10-10 16:39   ` Shengyu Qu
  0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2024-10-10  0:40 UTC (permalink / raw)
  To: Shengyu Qu
  Cc: linux, andrew, hkallweit1, davem, edumazet, pabeni, netdev,
	linux-kernel

On Sun, 6 Oct 2024 00:04:29 +0800 Shengyu Qu wrote:
> Seems Alcatel Lucent G-010S-P also have the same problem that it uses
> TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.

Looks like your email client (or server) has corrupted the patch.
Please try resending using git send-email?
-- 
pw-bot: cr

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] net: sfp: change quirks for Alcatel Lucent G-010S-P
  2024-10-10  0:40 ` Jakub Kicinski
@ 2024-10-10 16:39   ` Shengyu Qu
  0 siblings, 0 replies; 3+ messages in thread
From: Shengyu Qu @ 2024-10-10 16:39 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: wiagn233, linux, andrew, hkallweit1, davem, edumazet, pabeni,
	netdev, linux-kernel

Hello Jakub,

Sorry, I can't. Outlook has just disabled using password to log into
smtp server and Oauth2 is the only choice. And I don't know how to
configure git send-email to use it. So I copied the text in patch file
and send it using thunderbird.

Best regards,
Shengyu

在 2024/10/10 8:40, Jakub Kicinski 写道:
> On Sun, 6 Oct 2024 00:04:29 +0800 Shengyu Qu wrote:
>> Seems Alcatel Lucent G-010S-P also have the same problem that it uses
>> TX_FAULT pin for SOC uart. So apply sfp_fixup_ignore_tx_fault to it.
> 
> Looks like your email client (or server) has corrupted the patch.
> Please try resending using git send-email?


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-10 16:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-05 16:04 [PATCH v1] net: sfp: change quirks for Alcatel Lucent G-010S-P Shengyu Qu
2024-10-10  0:40 ` Jakub Kicinski
2024-10-10 16:39   ` Shengyu Qu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).