* [PATCH] net: bgmac: use devm for register_netdev
@ 2024-10-06 1:39 Rosen Penev
2024-10-06 2:07 ` Rosen Penev
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rosen Penev @ 2024-10-06 1:39 UTC (permalink / raw)
To: netdev
Cc: Rafał Miłecki, Broadcom internal kernel review list,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
Removes need to unregister in _remove.
Tested on ASUS RT-N16. No change in behavior.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/broadcom/bgmac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 6ffdc4229407..2599ffe46e27 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1546,7 +1546,7 @@ int bgmac_enet_probe(struct bgmac *bgmac)
bgmac->in_init = false;
- err = register_netdev(bgmac->net_dev);
+ err = devm_register_netdev(bgmac->dev, bgmac->net_dev);
if (err) {
dev_err(bgmac->dev, "Cannot register net device\n");
goto err_phy_disconnect;
@@ -1568,7 +1568,6 @@ EXPORT_SYMBOL_GPL(bgmac_enet_probe);
void bgmac_enet_remove(struct bgmac *bgmac)
{
- unregister_netdev(bgmac->net_dev);
phy_disconnect(bgmac->net_dev->phydev);
netif_napi_del(&bgmac->napi);
bgmac_dma_free(bgmac);
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bgmac: use devm for register_netdev
2024-10-06 1:39 [PATCH] net: bgmac: use devm for register_netdev Rosen Penev
@ 2024-10-06 2:07 ` Rosen Penev
2024-10-10 0:41 ` Jakub Kicinski
2024-10-10 3:32 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Rosen Penev @ 2024-10-06 2:07 UTC (permalink / raw)
To: netdev
Cc: Rafał Miłecki, Broadcom internal kernel review list,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
On Sat, Oct 5, 2024 at 6:39 PM Rosen Penev <rosenp@gmail.com> wrote:
>
> Removes need to unregister in _remove.
>
> Tested on ASUS RT-N16. No change in behavior.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
yikes. I wanted this in net-next.
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index 6ffdc4229407..2599ffe46e27 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -1546,7 +1546,7 @@ int bgmac_enet_probe(struct bgmac *bgmac)
>
> bgmac->in_init = false;
>
> - err = register_netdev(bgmac->net_dev);
> + err = devm_register_netdev(bgmac->dev, bgmac->net_dev);
> if (err) {
> dev_err(bgmac->dev, "Cannot register net device\n");
> goto err_phy_disconnect;
> @@ -1568,7 +1568,6 @@ EXPORT_SYMBOL_GPL(bgmac_enet_probe);
>
> void bgmac_enet_remove(struct bgmac *bgmac)
> {
> - unregister_netdev(bgmac->net_dev);
> phy_disconnect(bgmac->net_dev->phydev);
> netif_napi_del(&bgmac->napi);
> bgmac_dma_free(bgmac);
> --
> 2.46.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bgmac: use devm for register_netdev
2024-10-06 1:39 [PATCH] net: bgmac: use devm for register_netdev Rosen Penev
2024-10-06 2:07 ` Rosen Penev
@ 2024-10-10 0:41 ` Jakub Kicinski
2024-10-10 3:32 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-10-10 0:41 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Rafał Miłecki,
Broadcom internal kernel review list, David S. Miller,
Eric Dumazet, Paolo Abeni, open list
On Sat, 5 Oct 2024 18:39:37 -0700 Rosen Penev wrote:
> Removes need to unregister in _remove.
>
> Tested on ASUS RT-N16. No change in behavior.
I defer to the maintainer (Rafał) on whether it makes sense or not.
My personal preference is to leave existing code be.
*Iff* you get an ack please repost, it's the oldest patch in our
patchwork now.
--
pw-bot: defer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bgmac: use devm for register_netdev
2024-10-06 1:39 [PATCH] net: bgmac: use devm for register_netdev Rosen Penev
2024-10-06 2:07 ` Rosen Penev
2024-10-10 0:41 ` Jakub Kicinski
@ 2024-10-10 3:32 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2024-10-10 3:32 UTC (permalink / raw)
To: Rosen Penev, netdev
Cc: Rafał Miłecki, Broadcom internal kernel review list,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
On 10/5/2024 6:39 PM, Rosen Penev wrote:
> Removes need to unregister in _remove.
>
> Tested on ASUS RT-N16. No change in behavior.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-10 3:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-06 1:39 [PATCH] net: bgmac: use devm for register_netdev Rosen Penev
2024-10-06 2:07 ` Rosen Penev
2024-10-10 0:41 ` Jakub Kicinski
2024-10-10 3:32 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).