From: Jakub Kicinski <kuba@kernel.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: netdev@vger.kernel.org, donald.hunter@gmail.com,
pabeni@redhat.com, davem@davemloft.net, edumazet@google.com
Subject: Re: [PATCH] tools: ynl-gen: include auto-generated uAPI header only once
Date: Wed, 9 Oct 2024 19:19:06 -0700 [thread overview]
Message-ID: <20241009191906.573136e8@kernel.org> (raw)
In-Reply-To: <20241009121235.4967-1-a@unstable.cc>
On Wed, 9 Oct 2024 14:12:35 +0200 Antonio Quartulli wrote:
> The auto-generated uAPI file is currently included in both the
> .h and .c netlink stub files.
> However, the .c file already includes its .h counterpart, thus
> leading to a double inclusion of the uAPI header.
>
> Prevent the double inclusion by including the uAPI header in the
> .h stub file only.
FWIW I don't have a strong opinion either way.
Since both files are auto-generated there is no risk of getting it
wrong. Then again the win is fairly minor if any.
But if we want to do this why only remove the uapi header?
Netlink headers are also included twice.
prev parent reply other threads:[~2024-10-10 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 12:12 [PATCH] tools: ynl-gen: include auto-generated uAPI header only once Antonio Quartulli
2024-10-09 12:50 ` Jiri Pirko
2024-10-09 13:00 ` Antonio Quartulli
2024-10-09 13:37 ` Jiri Pirko
2024-10-09 13:53 ` Antonio Quartulli
2024-10-10 2:19 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009191906.573136e8@kernel.org \
--to=kuba@kernel.org \
--cc=a@unstable.cc \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).